From: Jonathan Corbet <corbet@lwn.net>
To: David Vernet <void@manifault.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@meta.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
memxor@gmail.com
Subject: Re: [PATCH bpf-next v2 3/3] bpf: Use BPF_KFUNC macro at all kfunc definitions
Date: Tue, 24 Jan 2023 07:50:31 -0700 [thread overview]
Message-ID: <87lelsgf60.fsf@meer.lwn.net> (raw)
In-Reply-To: <Y88sMlmrq0wCFSRP@maniforge.lan>
David Vernet <void@manifault.com> writes:
> I was perhaps a bit naive to think we could just throw a __bpf_kfunc
> macro onto the function signatures and call it a day :-) I think it's
> probably best to table this for now, and either I or someone else can
> come back to it when we have bandwidth to solve the problem more
> appropriately.
Now I feel bad ... I was just tossing out a thought, not wanting to
bikeshed this work into oblivion. If what you have solves a real
problem and is the best that can be done now, perhaps it should just go
in and a "more appropriate" solution can be adopted later, should
somebody manage to come up with it?
Thanks,
jon
next prev parent reply other threads:[~2023-01-24 14:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 17:15 [PATCH bpf-next v2 0/3] Add BPF_KFUNC macro for kfunc definitions David Vernet
2023-01-23 17:15 ` [PATCH bpf-next v2 1/3] bpf: Add BPF_KFUNC macro for defining kfuncs David Vernet
2023-01-23 17:15 ` [PATCH bpf-next v2 2/3] bpf: Document usage of the new BPF_KFUNC macro David Vernet
2023-01-23 17:15 ` [PATCH bpf-next v2 3/3] bpf: Use BPF_KFUNC macro at all kfunc definitions David Vernet
2023-01-23 18:33 ` Alexei Starovoitov
2023-01-23 18:48 ` David Vernet
2023-01-23 18:54 ` Alexei Starovoitov
2023-01-23 19:01 ` David Vernet
2023-01-23 19:04 ` Daniel Borkmann
2023-01-23 21:00 ` Jonathan Corbet
2023-01-24 0:54 ` David Vernet
2023-01-24 14:50 ` Jonathan Corbet [this message]
2023-01-24 16:20 ` David Vernet
2023-01-31 15:15 ` Alan Maguire
2023-01-31 15:44 ` David Vernet
2023-01-31 17:30 ` Alexei Starovoitov
2023-01-23 19:01 ` kernel test robot
2023-01-23 19:12 ` kernel test robot
2023-01-24 7:15 ` Christoph Hellwig
2023-01-24 14:15 ` David Vernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelsgf60.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=void@manifault.com \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox