From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B7EC001B5 for ; Fri, 2 Sep 2022 15:36:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237106AbiIBPgZ (ORCPT ); Fri, 2 Sep 2022 11:36:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236291AbiIBPf4 (ORCPT ); Fri, 2 Sep 2022 11:35:56 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51B78E01B; Fri, 2 Sep 2022 08:22:31 -0700 (PDT) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C820460006; Fri, 2 Sep 2022 15:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662132147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0rUQ2l1vmxKVWa5erxjAKkxBEimIvilXH9518mHXTCQ=; b=ArAcloKF2gpYqLLWLWj9bhOoXp41UPTmvqZBo+tnkQ5EpY2kGXhE9y810eNmvNgAHzo0v0 yANUj2fuNFDu8s3f1O/3UH0M2dc8A4LA/ryOm96ZJmN+nkJdWym0qiJrWUrJrTbCiQkWJW g5P209xC/ihrHRppLivqttLzlinUL+FxhxeMN7xBhqG08oFFGB/XR6nbbPbV5PJ2tx8DQd 3csjL1oxNFY9lBNaRYXDP6M266pOdul8q5Qe8L665UWE3SHpOiFdkbkIgsO1jRv5KLWL8l zxGoCaWb8/JjAjGR1YiwkyDkcr9IYFp0D/7vuyLmEkhUa8L683NuoI7AzhZDQQ== From: Gregory CLEMENT To: Robert Marko Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, kostap@marvell.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski Subject: Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU In-Reply-To: References: <20220516124828.45144-1-robert.marko@sartura.hr> <20220516124828.45144-10-robert.marko@sartura.hr> <87mtbm5gaf.fsf@BL-laptop> Date: Fri, 02 Sep 2022 17:22:24 +0200 Message-ID: <87ler1er7z.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Marko writes: > On Tue, Aug 30, 2022 at 9:42 AM Gregory CLEMENT > wrote: >> >> Robert Marko writes: >> >> > On Mon, May 16, 2022 at 2:48 PM Robert Marko wrote: >> >> >> >> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU. >> >> >> >> They feature the same CPU, RAM, and storage as well as the form factor. >> >> >> >> However, eDPU only has one SFP slot plus a copper G.hn port. >> >> >> >> Signed-off-by: Robert Marko >> >> Reviewed-by: Krzysztof Kozlowski >> >> --- >> >> Changes in v2: >> >> * Make the DTS split a separate commit >> >> --- >> >> arch/arm64/boot/dts/marvell/Makefile | 1 + >> >> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++ >> >> 2 files changed, 15 insertions(+) >> >> create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts >> >> >> >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile >> >> index 1c794cdcb8e6..104d7d7e8215 100644 >> >> --- a/arch/arm64/boot/dts/marvell/Makefile >> >> +++ b/arch/arm64/boot/dts/marvell/Makefile >> >> @@ -1,6 +1,7 @@ >> >> # SPDX-License-Identifier: GPL-2.0 >> >> # Mvebu SoC Family >> >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb >> >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb >> >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb >> >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb >> >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb >> >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts >> >> new file mode 100644 >> >> index 000000000000..57fc698e55d0 >> >> --- /dev/null >> >> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts >> >> @@ -0,0 +1,14 @@ >> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> >> + >> >> +/dts-v1/; >> >> + >> >> +#include "armada-3720-uDPU.dtsi" >> >> + >> >> +/ { >> >> + model = "Methode eDPU Board"; >> >> + compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710"; >> >> +}; >> >> + >> >> +ð0 { >> >> + phy-mode = "2500base-x"; >> >> +}; >> >> -- >> >> 2.36.1 >> >> >> > >> > Hi Gregory, >> Hello Roberto, >> >> > Is there something else that I can improve in the series? >> >> Sorry for having missed this series. At first view it seems OK, I am >> going to have a closer look this week. > > Thanks, that sounds good. Hello, could you send again patch 8, I managed to apply all the other ones excepting this one. Thanks, Gregory > > Regards, > Robert >> >> Gregory >> >> >> > >> > Regards, >> > Robert >> > >> > -- >> > Robert Marko >> > Staff Embedded Linux Engineer >> > Sartura Ltd. >> > Lendavska ulica 16a >> > 10000 Zagreb, Croatia >> > Email: robert.marko@sartura.hr >> > Web: www.sartura.hr >> >> -- >> Gregory Clement, Bootlin >> Embedded Linux and Kernel engineering >> http://bootlin.com > > > > -- > Robert Marko > Staff Embedded Linux Engineer > Sartura Ltd. > Lendavska ulica 16a > 10000 Zagreb, Croatia > Email: robert.marko@sartura.hr > Web: www.sartura.hr -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com