From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E79C433EF for ; Sat, 4 Jun 2022 06:32:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350682AbiFDGch (ORCPT ); Sat, 4 Jun 2022 02:32:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232461AbiFDGcc (ORCPT ); Sat, 4 Jun 2022 02:32:32 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D4BA1570C for ; Fri, 3 Jun 2022 23:32:31 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 277B51F9D7; Sat, 4 Jun 2022 06:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1654324350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZJG5guBLIWAz3SOQLZZH/juzO/cxYO498RczU/vkaSk=; b=wDg3/pNdv9USmjeOpBn+9qovNEcNNzlHkfgU3z3GmBg8Yy2x0xYGgOWBNTSz8s6mgNKyMW yr239KFYqskkQwKVe+ypcoiw2PtQ14CopV9K4al/+8zKybu6yhkbQRGpriy1DPQv7/D8Ff HbT+mnIaG7RY10m0ECkJ9iMzr5R4Zo4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1654324350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZJG5guBLIWAz3SOQLZZH/juzO/cxYO498RczU/vkaSk=; b=KVeLdW++j9mp7z7swg6Q0b62Z8DxkAaufZPuVDq1Bo0BDOu5niZ1zNu74VOBAFsj/Pu4X5 iHZleBDGKNvVeiBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D8B4213A8F; Sat, 4 Jun 2022 06:32:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id E5oqNH38mmLSOQAAMHmgww (envelope-from ); Sat, 04 Jun 2022 06:32:29 +0000 Date: Sat, 04 Jun 2022 08:32:29 +0200 Message-ID: <87leud0whu.wl-tiwai@suse.de> From: Takashi Iwai To: Linus Torvalds Cc: Greg KH , Takashi Iwai , Andrew Morton , Linux Kernel Mailing List , Stephen Rothwell , Saravana Kannan Subject: Re: [GIT PULL] Driver core changes for 5.19-rc1 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 04 Jun 2022 00:23:18 +0200, Linus Torvalds wrote: > > Augh. > > This was very badly done, and I'm not talking about the deferred probe > timeout things that caused problems for people. > > On Fri, Jun 3, 2022 at 4:28 AM Greg KH wrote: > > > > - firmware_loader reorganization and additions including the > > ability to have XZ compressed firmware images and the ability > > for userspace to initiate the firmware load when it needs to, > > instead of being always initiated by the kernel. > > This is actively misleading. > > We *always* supported XZ compressed firmware images, and it was > enabled by CONFIG_FW_LOADER_COMPRESS, > > What's new is the option to use ZSTD compression. > > However, the Kconfig file addition for this was done as badly as the > above explanation was, and the FW_LOADER_COMPRESS_XZ option was added > with a help message and a default value that both are complete > garbage. > > So when you do "make oldconfig", you would be expected to say 'N', and > in the process you lose the existing XZ compression. > > Only when the resulting kernel doesn't boot, and you spent half an > hour trying to bisect things, and you start looking closer, do you > notice that "ooh, the config changed in bad ways". > > Yeah, I'm a bit grumpy. This was *really* annoying. > > The commit that does this breakage is literally called "firmware: Add > the support for ZSTD-compressed firmware files", and only when looking > closer do you notice that IT REMOVES SUPPORT FOR XZ COMPRESSION BY > DEFAULT. > > Because even when keeping the FW_LOADER_COMPRESS option enabled, the > XZ compression is just gone, gone, gone, unless you realize that it > was implicitly enabled before, and now needs that default disable of > FW_LOADER_COMPRESS_XZ to be enabled. > > I've said this before, and I'll say it here again (and I bet I'll have > to say it in the future too): the kernel config is probably the most > annoying part of building a kernel for anybody. > > And it damn well does NOT HELP when people then actively break things, > and ask actively bad and misleading questions. In this case, for > example, it's not just that the XZ option is now misleading by > default, it's also that the whole thing has been set up so that you > can say "enable compressed images", but then HAVE NO ACTUAL > COMPRESSION METHOD! > > Grr. This was *REALLY* badly done. Mea culpa, I hesitated to add "default y", but it should have been added at least for the case with the config takeover case. Now I see that you've already added "default y" to CONFIG_FW_LOADER_COMPRESS_XZ. Thanks for taking care of this! Takashi