From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54D5C433F5 for ; Fri, 20 May 2022 08:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346803AbiETICp (ORCPT ); Fri, 20 May 2022 04:02:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346771AbiETICn (ORCPT ); Fri, 20 May 2022 04:02:43 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD4939810 for ; Fri, 20 May 2022 01:02:43 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id B82A521C96; Fri, 20 May 2022 08:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1653033761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4dyUHFa2rIcc2e9oqlM5k+EFPG8cyRAb8yrunmcF9hY=; b=xcESGwPy0Oxm8ptaMYTeQ1ZUtWS7igSONK/J1gei8hDXK5TxtVUMbHlvSvUQ+VvfdqjA2z b5FRJvkFB8kjiGesex4wRf1LZb0OpJuZ8tIJiyI7Dh4D24rchxdyQ0GVUDjJbelPcZAgkq TgGHfcbTnCwHe4b1mpnZVhzT8xDLkKY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1653033761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4dyUHFa2rIcc2e9oqlM5k+EFPG8cyRAb8yrunmcF9hY=; b=2vqju6SyMmmrV/hF8pQp+vdFfGjAiivQJBMAbq4l/eQLpLOq0D/Alfa8fDgCzc+RUuwSwr 9cJguiVGdFSpsiBg== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 8ED052C141; Fri, 20 May 2022 08:02:41 +0000 (UTC) Date: Fri, 20 May 2022 10:02:41 +0200 Message-ID: <87leuwr5r2.wl-tiwai@suse.de> From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , "Mark Brown" , , , , Vitaly Rodionov Subject: Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading In-Reply-To: <87mtfcr5v1.wl-tiwai@suse.de> References: <20220519174749.15459-1-vitalyr@opensource.cirrus.com> <20220519174749.15459-5-vitalyr@opensource.cirrus.com> <87mtfcr5v1.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 May 2022 10:00:18 +0200, Takashi Iwai wrote: > > On Thu, 19 May 2022 19:47:36 +0200, > Vitaly Rodionov wrote: > > > > From: Vitaly Rodionov > > > > This patch adds support for the CS35L41 DSP. > > The DSP allows for extra features, such as running > > speaker protection algorithms and hibernations. > > > > To utilize these features, the driver must load > > firmware into the DSP, as well as various tuning > > files which allow for cusomtization for specific > > models. > > Wouldn't this sequence be required after S3/S4 resume? > I thought cs35l41_hda_bind() is called only at the first binding. OK, I see that the later patches in the series are about hibernation. It might be good to mention that in this patch, though. Takashi