From: Thomas Gleixner <tglx@linutronix.de>
To: Chao Liu <liuchao173@huawei.com>,
linux-kernel@vger.kernel.org, hewenliang4@huawei.com
Cc: steven.price@arm.com, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] cpu/hotplug: check the return value of idle_thread_get
Date: Wed, 18 May 2022 10:55:37 +0200 [thread overview]
Message-ID: <87leuzjk3a.ffs@tglx> (raw)
In-Reply-To: <20230327203728.159123-1-liuchao173@huawei.com>
On Mon, Mar 27 2023 at 20:37, Chao Liu wrote:
> ilde may be ERR_PTR()
Yes, but if that happens in bringup_cpu() or finish_cpu() it would be a
serious bug and the error pointer dereference would be the least of the
problems.
If the initial check in _cpu_up() failed for a CPU then the above
functions cannot be invoked for that CPU ever.
Thanks,
tglx
prev parent reply other threads:[~2022-05-18 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 20:37 [PATCH] cpu/hotplug: check the return value of idle_thread_get Chao Liu
2022-05-18 8:55 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leuzjk3a.ffs@tglx \
--to=tglx@linutronix.de \
--cc=hewenliang4@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuchao173@huawei.com \
--cc=peterz@infradead.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox