From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20473C433FE for ; Thu, 14 Apr 2022 12:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243230AbiDNM11 (ORCPT ); Thu, 14 Apr 2022 08:27:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243184AbiDNM1I (ORCPT ); Thu, 14 Apr 2022 08:27:08 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5D9F32CE34 for ; Thu, 14 Apr 2022 05:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649939083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w3YBdRKJUuRVoqjsuVYs7FMkqCpz3SW587vkpc0Rrvg=; b=iUnN5q0ZbfakU7j4xFu2WGxledK1F5TrxOwEkwu7yKVTwIUcljoXDjRw3tfN400vzoUVqT EY2jcWeDv4fy/ZxdgAcskxaFOGRIISW7WGhlv1AaBnaNUxvL08CD82tXJriYafZAkutKwd mQ6i49pxNNSVi20ilznqkBlL6vImKtk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-sCsyIxa4MsaOEEwzBbrRTg-1; Thu, 14 Apr 2022 08:24:42 -0400 X-MC-Unique: sCsyIxa4MsaOEEwzBbrRTg-1 Received: by mail-wm1-f69.google.com with SMTP id g13-20020a1c4e0d000000b0038eba16aa46so2160341wmh.7 for ; Thu, 14 Apr 2022 05:24:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=w3YBdRKJUuRVoqjsuVYs7FMkqCpz3SW587vkpc0Rrvg=; b=M6MkUW98yVYG5S35uqxMCLDPxkWMofglFTOKK9R5ioObbcXf+HwD/CzpDAMWtEifiI 078pJ0hnZRZrqUlvulo63NJ8TuXxlmhllkW9qUSZdZXQ2t85iR3VLR2mswSBlXgciqyX edhQ4fb8sh5SbQ7wDKXkaSukbXy6DoM8/LUHuz/bg8gun6SxB9hBDpKpen/9/8CPh5UE 7VV0VDJH1Gh7F6fi1zmFWd0hL/RWWGjk0jSbpV8qqHVJEIPypSr8rFyDP6N4WE+Vf1dS bCMoMDP0iSJQUqFflLiQiKJGvxAwRBmdEaqc2hDuRypGvbKBHc15s0ajzzWlN8nHbxya +uBA== X-Gm-Message-State: AOAM531hsNaeCFX7xjrjiP6N9w7+TsRhe4Q5GXwSB35rCy1sFJYu4vcy iuKQoRC7O+3hxEZMFdIhFNXsot/1x6WE9mZcWUZRCEg2yQY59hWLGzJcyMGl0s3V5mJ6gTkdRLC FdjxXrlxAFVU6CnmRDHbryh3/+yxvPzk1D4J3A7k3BiZPjykJUHkNE5aldp4fDBzj3CB7tgkyZR Wn X-Received: by 2002:a05:6000:1acf:b0:203:fe67:a8dc with SMTP id i15-20020a0560001acf00b00203fe67a8dcmr1939010wry.212.1649939080930; Thu, 14 Apr 2022 05:24:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzXxuDleRxU9n7P7jE2XBRIfRSmIzpph4ijPoFszyxobCWls/GbBpEwYTZXs/vLQg4+4xeFg== X-Received: by 2002:a05:6000:1acf:b0:203:fe67:a8dc with SMTP id i15-20020a0560001acf00b00203fe67a8dcmr1938985wry.212.1649939080646; Thu, 14 Apr 2022 05:24:40 -0700 (PDT) Received: from fedora (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id r14-20020a0560001b8e00b00205918bd86esm1671555wru.78.2022.04.14.05.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 05:24:39 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/31] KVM: x86: hyper-v: Direct TLB flush In-Reply-To: References: <20220407155645.940890-1-vkuznets@redhat.com> <20220407155645.940890-14-vkuznets@redhat.com> Date: Thu, 14 Apr 2022 14:24:38 +0200 Message-ID: <87lew76eex.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sean Christopherson writes: > On Thu, Apr 07, 2022, Vitaly Kuznetsov wrote: >> Handle Direct TLB flush requests from L2 by going through all vCPUs > > What is a "Direct TLB flush request" in this context? I can't tell if "direct" > refers to the MMU being direct, or if it has some other Hyper-V specific meaning. > > Ewww, it looks to be Hyper-V terminology. Now I see that @direct=true is getting > L2's ring, not L1's ring. That's all kinds of evil. That confusion goes away with > my suggestion below, but this shortlog and changelog (and the ones for nVMX and > nSVM enabling) absolutely need to clarify "direct" since it conflicts mightily > with KVM's "direct" terminology. > > In fact, unless I'm missing a patch where "Direct" doesn't mean "From L2", I vote > to not use the "Direct TLB flush" terminology in any of the shortlogs or changelogs > and only add a footnote to this first changelog to call out that the TLFS (or > wherever this terminology came from) calls these types of flushes > "Direct". In soon-to-be-sent-out v3 I got rid of 'Direct TLB flush' completely. Note, in addition to what gets introduced in this series, there are two other Hyper-V specific places which overload 'direct' already: - Direct TLB flush for KVM-on-Hyper-V (enable_direct_tlbflush()). I'm getting rid of it too. - Direct synthetic timers. 'Direct' in this case means that the timer signal is delivered via dedicated IRQ 'directly' and not through Vmbus message. This stays as I can't think of how we can rename it (and if we should, in the first place). -- Vitaly