From: Jonathan Corbet <corbet@lwn.net>
To: "Akira Yokosawa" <akiyks@gmail.com>,
"Tomasz Warniełło" <tomasz.warniello@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: scripts/kernel-doc: Detect absence of FILE arg
Date: Thu, 24 Feb 2022 12:15:15 -0700 [thread overview]
Message-ID: <87ley0krek.fsf@meer.lwn.net> (raw)
In-Reply-To: <7b136049-a3ba-0eb5-8717-364d773ff914@gmail.com>
Akira Yokosawa <akiyks@gmail.com> writes:
> Currently, when there is no FILE argument following a switch such
> as -man, -rst, or -none, kernel-doc exits with a warning from perl
> (long msg folded):
>
> Use of uninitialized value $ARGV[0] in pattern match (m//)
> at ./scripts/kernel-doc line 438.
>
> , which is unhelpful.
>
> Improve the behavior by adding a check at the bottom of parsing
> loop.
> If the argument is absent, display help text and exit with
> the code of 1 (via usage()).
As might be expected, this applied poorly after the pod patches went in.
I went ahead and resolved the conflict, substituting an appropriate
pod2usage() call.
Thanks,
jon
prev parent reply other threads:[~2022-02-24 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 13:02 [PATCH v2] docs: scripts/kernel-doc: Detect absence of FILE arg Akira Yokosawa
2022-02-24 19:15 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ley0krek.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akiyks@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tomasz.warniello@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox