From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C2FC433F5 for ; Wed, 3 Nov 2021 18:38:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC98F60E9B for ; Wed, 3 Nov 2021 18:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231211AbhKCSkl (ORCPT ); Wed, 3 Nov 2021 14:40:41 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:52124 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230258AbhKCSkh (ORCPT ); Wed, 3 Nov 2021 14:40:37 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]:43636) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1miL95-000YWJ-Ec; Wed, 03 Nov 2021 12:37:59 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:53250 helo=email.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1miL93-00Bv7w-Lt; Wed, 03 Nov 2021 12:37:58 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Kees Cook Cc: Andy Lutomirski , Will Drewry , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-hardening@vger.kernel.org References: <20211103163039.2104830-1-keescook@chromium.org> Date: Wed, 03 Nov 2021 13:37:51 -0500 In-Reply-To: <20211103163039.2104830-1-keescook@chromium.org> (Kees Cook's message of "Wed, 3 Nov 2021 09:30:37 -0700") Message-ID: <87lf253x1c.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1miL93-00Bv7w-Lt;;;mid=<87lf253x1c.fsf@disp2133>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/H9jK5N9976jNzDSgqO04BsgEtCX+f4KM= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 0/2] selftests/seccomp: Report event mismatches more clearly X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > Hi, > > This expands the seccomp selftests slightly to add additional debug > reporting detail and a new "immediate fatal SIGSYS under tracing" test. > I expect to be taking these via my seccomp tree. Acked-by: "Eric W. Biederman" I am a little fuzzy on the details but I understand what and why you are testing (I broken it). So this is my 10,000 foot ack. Eric > Thanks, > > -Kees > > Kees Cook (2): > selftests/seccomp: Stop USER_NOTIF test if kcmp() fails > selftests/seccomp: Report event mismatches more clearly > > tools/testing/selftests/seccomp/seccomp_bpf.c | 56 +++++++++++++++++-- > 1 file changed, 50 insertions(+), 6 deletions(-)