From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AB1C433F5 for ; Mon, 20 Sep 2021 07:03:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1782C61074 for ; Mon, 20 Sep 2021 07:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233609AbhITHEk (ORCPT ); Mon, 20 Sep 2021 03:04:40 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:40294 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233629AbhITHEV (ORCPT ); Mon, 20 Sep 2021 03:04:21 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632121373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PyM/RfJt0D4t8AyTheIl5UBEkGQN9Z7Je9+vK9jPaBE=; b=bCnhREcfGejQYrSDL6iBTTOLkn6c+kCWfi4UZ/+4AuAhJlkfc2v5ge9uutcbRaS90rx7oE P73f/epC2dBxGvKbiB3CzW4g/EypwbGCpoSHKhh+ESIU/hPND18NVjo90AkwRICUPi31Zh bR02bWodFXMIHE0z1GmG66hvS7iMV/A3J7Y7dMn1nwJgi0pZiTmhNPcd8owwjY4W8/i5iR /hzGKQ2GXybK8nAV8ZiIXM8P/8bULmQjOxJwNtWvEvdccDjsFzqSo89B3XkYGoXpU0UxiJ iXoS7qYc0He2eBTukZdpXWWNjtqdqK/Ttl4q2TKV2zh8hZp73E5Ci6eUGs2qmg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632121373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PyM/RfJt0D4t8AyTheIl5UBEkGQN9Z7Je9+vK9jPaBE=; b=+Bo+8Euft3f4goj3Z1zauLuEkIa0dEqj7XvrB179V6+nFEZMqdwdwDJbNhVIMNJFXS8gef ZGclBbEbeJHDdjBg== To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , Dave Hansen , Yang Shi , Zi Yan , Michal Hocko , Wei Xu , Oscar Salvador , David Rientjes , Dan Williams , David Hildenbrand , Greg Thelen , Keith Busch Subject: Re: [PATCH] mm/migrate: fix CPUHP state to update node demotion order In-Reply-To: <20210918025849.88901-1-ying.huang@intel.com> References: <20210918025849.88901-1-ying.huang@intel.com> Date: Mon, 20 Sep 2021 09:02:52 +0200 Message-ID: <87lf3r7mqr.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 18 2021 at 10:58, Huang Ying wrote: > @@ -72,6 +72,7 @@ enum cpuhp_state { > CPUHP_SLUB_DEAD, > CPUHP_DEBUG_OBJ_DEAD, > CPUHP_MM_WRITEBACK_DEAD, > + CPUHP_MM_DEMOTION_OFFLINE, Please keep the _DEAD convention in that section. The plugged CPU is already gone. > CPUHP_MM_VMSTAT_DEAD, > CPUHP_SOFTIRQ_DEAD, > CPUHP_NET_MVNETA_DEAD, > @@ -240,6 +241,7 @@ enum cpuhp_state { > CPUHP_AP_BASE_CACHEINFO_ONLINE, > CPUHP_AP_ONLINE_DYN, > CPUHP_AP_ONLINE_DYN_END = CPUHP_AP_ONLINE_DYN + 30, > + CPUHP_AP_MM_DEMOTION_ONLINE, Are there any ordering requirements of these states vs. other CPU hotplug states? If not, then please use the dynamically allocated states. If so, then please add a comment: + /* Must be before CPUHP_XXX and after CPUHP_YYY */ + CPUHP_MM_DEMOTION_OFFLINE, Thanks, tglx