From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6035C433ED for ; Thu, 22 Apr 2021 23:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C30F561405 for ; Thu, 22 Apr 2021 23:09:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239855AbhDVXJy (ORCPT ); Thu, 22 Apr 2021 19:09:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbhDVXJx (ORCPT ); Thu, 22 Apr 2021 19:09:53 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AF11C061574 for ; Thu, 22 Apr 2021 16:09:16 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id h20so24320066plr.4 for ; Thu, 22 Apr 2021 16:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=I+ChA608q5PY2OZr5MkEs6pE5PCTHTer03gvn9b4wsk=; b=lftAUNTqFM1CixvAqF0/mXn2BtvZ8zs8b4UbV/ZoVc3MpnfmVQ1rzz78UrBE4iPPlk MkjlcDHV/7+vkzhw9DgvNrU6eh2/LJLyDJUecSH+gqXBStdHjzcoaucuOXj7rtG6v0Yi XQS2CU5y7uM5PKFFK8xaEjHvowH4P3oDz3DZ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=I+ChA608q5PY2OZr5MkEs6pE5PCTHTer03gvn9b4wsk=; b=FgqDXfs3XpGcTRP2MHFi2pVDJV/67lx+IixMW3LSp3mDHlbDZdjfPLkKno+raHBNy8 /5MKQFvitp6nERkSPrKZNyTkg5qWl09Mkxrz6jmTI78c8CS4/ZOLFgnxk8D2DNo81vwk qRZIdWQGXFEfLg/Vur63QA6h6LQpfTLx6p4W0pesIDpluXJkwx4rWiEQtENSTEEkK/se vUhYEZ/T9H1zvY7Ry10U+wG1Kz5PhkAGyqG6/kcdhW3QoIVJIy1JDIlq6DO0Au8hEjdI BJYoJ9PfycmFxJ5E9oHvFlAIBaZxkED1MWPJePE3Xg04PBHqDsIa0BxMKs9L/Pgl0mbE IC4w== X-Gm-Message-State: AOAM533szUv+AoKGBazP2fjdu8QTWUVqAZpYMYd2UoClSt8Nqkb6AUG1 D3gPeHzDIvr3U2jkQGrzCpJSQA== X-Google-Smtp-Source: ABdhPJwCBaie9yuLL90yVwDtCXeYnxlBEOFwUMRH3KjeOBuPd80mSfqouLqOvdcMa/F/prJJgFlElw== X-Received: by 2002:a17:902:e546:b029:ec:a7f5:2a88 with SMTP id n6-20020a170902e546b02900eca7f52a88mr1170687plf.21.1619132955742; Thu, 22 Apr 2021 16:09:15 -0700 (PDT) Received: from localhost (2001-44b8-111e-5c00-587a-8af2-ee3d-5684.static.ipv6.internode.on.net. [2001:44b8:111e:5c00:587a:8af2:ee3d:5684]) by smtp.gmail.com with ESMTPSA id h24sm5755525pjv.50.2021.04.22.16.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Apr 2021 16:09:15 -0700 (PDT) From: Daniel Axtens To: Nick Desaulniers , Michael Ellerman Cc: Nick Desaulniers , Nathan Chancellor , Joe Perches , Benjamin Herrenschmidt , Paul Mackerras , Oliver O'Halloran , Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/powernv/pci: remove dead code from !CONFIG_EEH In-Reply-To: <20210422195405.4053917-1-ndesaulniers@google.com> References: <20210422195405.4053917-1-ndesaulniers@google.com> Date: Fri, 23 Apr 2021 09:09:12 +1000 Message-ID: <87lf99zzl3.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nick, > While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a > possible candidate to convert to #ifdef CONFIG_EEH, but it seems that > based on Kconfig dependencies it's not possible to build this file > without CONFIG_EEH enabled. This seemed odd to me, but I think you're right: arch/powerpc/platforms/Kconfig contains: config EEH bool depends on (PPC_POWERNV || PPC_PSERIES) && PCI default y It's not configurable from e.g. make menuconfig because there's no prompt. You can attempt to explicitly disable it with e.g. `scripts/config -d EEH` but then something like `make oldconfig` will silently re-enable it for you. It's been forced on since commit e49f7a9997c6 ("powerpc/pseries: Rivet CONFIG_EEH for pSeries platform") in 2012 which fixed it for pseries. That moved out from pseries to pseries + powernv later on. There are other cleanups in the same vein that could be made, from the Makefile (which has files only built with CONFIG_EEH) through to other source files. It looks like there's one `#ifdef CONFIG_EEH` in arch/powerpc/platforms/powernv/pci-ioda.c that could be pulled out, for example. I think it's probably worth trying to rip out all of those in one patch? Kind regards, Daniel