From: Andreas Schwab <schwab@linux-m68k.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: akpm@linux-foundation.org, geert@linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS
Date: Sun, 28 Mar 2021 11:04:08 +0200 [thread overview]
Message-ID: <87lfa7ved3.fsf@linux-m68k.org> (raw)
In-Reply-To: <20210328041359.50149-1-julianbraha@gmail.com> (Julian Braha's message of "Sun, 28 Mar 2021 00:13:59 -0400")
On Mär 28 2021, Julian Braha wrote:
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2779c29d9981..8d53ed423899 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1665,7 +1665,7 @@ config LATENCYTOP
> depends on DEBUG_KERNEL
> depends on STACKTRACE_SUPPORT
> depends on PROC_FS
> - select FRAME_POINTER if !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
> + select FRAME_POINTER if MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
That doesn't look correct. It reverses the condition without reversing
the result, which means the result is probably the opposite than intended.
The same expression occurs two more times in this file. Do those need
to be changed as well?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-03-28 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 4:13 [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS Julian Braha
2021-03-28 8:45 ` Geert Uytterhoeven
2021-03-28 9:04 ` Andreas Schwab [this message]
2021-03-29 16:32 ` Julian Braha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfa7ved3.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox