From: Thomas Gleixner <tglx@linutronix.de>
To: Stephen Boyd <swboyd@chromium.org>, John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v2 3/3] alarmtimer: Always export alarmtimer_get_rtcdev() and update docs
Date: Fri, 24 Jan 2020 02:04:49 +0100 [thread overview]
Message-ID: <87lfpx1x72.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200121194811.145644-4-swboyd@chromium.org>
Stephen Boyd <swboyd@chromium.org> writes:
> The export isn't there for the stubbed version of
> alarmtimer_get_rtcdev(), so move the export outside of the ifdef. And
> rtcdev isn't used outside of this ifdef so we don't need to redefine it
> as NULL.
This does not make any sense. Why would we export a trivial stub which
just returns NULL?
The right thing to do is to make that an inline function in the relevant
header file.
> @@ -67,8 +67,6 @@ static DEFINE_SPINLOCK(rtcdev_lock);
> * alarmtimer_get_rtcdev - Return selected rtcdevice
> *
> * This function returns the rtc device to use for wakealarms.
> - * If one has not already been chosen, it checks to see if a
> - * functional rtc device is available.
Unrelated comment change which is not explained in the changelog. Please
make that a separate patch as it has absolutely nothing to do with the
stub function issue.
Thanks,
tglx
next prev parent reply other threads:[~2020-01-24 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 19:48 [PATCH v2 0/3] Fix alarmtimer suspend failure Stephen Boyd
2020-01-21 19:48 ` [PATCH v2 1/3] alarmtimer: Make alarmtimer platform device child of RTC device Stephen Boyd
2020-01-21 22:44 ` Stephen Boyd
2020-01-21 23:43 ` Doug Anderson
2020-01-21 19:48 ` [PATCH v2 2/3] alarmtimer: Use wakeup source from alarmtimer platform device Stephen Boyd
2020-01-21 23:45 ` Doug Anderson
2020-01-21 19:48 ` [PATCH v2 3/3] alarmtimer: Always export alarmtimer_get_rtcdev() and update docs Stephen Boyd
2020-01-24 1:04 ` Thomas Gleixner [this message]
2020-01-24 1:14 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfpx1x72.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dianders@chromium.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox