From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA79C35240 for ; Fri, 24 Jan 2020 01:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B047B2071E for ; Fri, 24 Jan 2020 01:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730253AbgAXBE5 (ORCPT ); Thu, 23 Jan 2020 20:04:57 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:41273 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729789AbgAXBE5 (ORCPT ); Thu, 23 Jan 2020 20:04:57 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iunOz-0002FU-R1; Fri, 24 Jan 2020 02:04:49 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 2C1EF100490; Fri, 24 Jan 2020 02:04:49 +0100 (CET) From: Thomas Gleixner To: Stephen Boyd , John Stultz Cc: linux-kernel@vger.kernel.org, Stephen Boyd , Douglas Anderson Subject: Re: [PATCH v2 3/3] alarmtimer: Always export alarmtimer_get_rtcdev() and update docs In-Reply-To: <20200121194811.145644-4-swboyd@chromium.org> References: <20200121194811.145644-1-swboyd@chromium.org> <20200121194811.145644-4-swboyd@chromium.org> Date: Fri, 24 Jan 2020 02:04:49 +0100 Message-ID: <87lfpx1x72.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Boyd writes: > The export isn't there for the stubbed version of > alarmtimer_get_rtcdev(), so move the export outside of the ifdef. And > rtcdev isn't used outside of this ifdef so we don't need to redefine it > as NULL. This does not make any sense. Why would we export a trivial stub which just returns NULL? The right thing to do is to make that an inline function in the relevant header file. > @@ -67,8 +67,6 @@ static DEFINE_SPINLOCK(rtcdev_lock); > * alarmtimer_get_rtcdev - Return selected rtcdevice > * > * This function returns the rtc device to use for wakealarms. > - * If one has not already been chosen, it checks to see if a > - * functional rtc device is available. Unrelated comment change which is not explained in the changelog. Please make that a separate patch as it has absolutely nothing to do with the stub function issue. Thanks, tglx