From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2853752-1516851037-2-6877938235327200276 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: X-Attached: signature.asc X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516851036; b=HY+4LK6k6ujXajQ465KPCoOlli4pJKKwNOX89NeZZa9rAUL Z7dBPrMtwLMgurNKhrb0Y2jX1iXHlMFpl9lxQQ1Dzkcp04oMD405q6SA7MtZceqg /ZTmf4UwTSpvdy5To9A7UY5fLNnjyjWAz/8qZXu/eUcrsaDb2G8n6H6nn3Fu43ls BhFOhxy6WeHZM3ECx2Jb0tQWw4SDFDj7wsewbqahGLMO5oQx0ETmpld8JwWbg6z/ Kn55BzqTbnux5UCyXFPbJfOTLsLBl/pJHrLJ+mzd9Wi6Ut7LSAprA5k0YZqVLCp3 U9ReL0XNjGY7qPdpQrENQv1lKmitUyUGbW81liw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:in-reply-to:references :date:message-id:mime-version:content-type:sender:list-id; s= arctest; t=1516851036; bh=OdD6OlF3DX6CVligFQjIW728HDRSsYmN2wdpNp Z3w6M=; b=UuGaX3VsszxdMZkyI/ZXeaZRtAPuf/wj01Kq2qGPeKryt6SfD5PMok xJS+DTmMID/7CRWSOwfrP5Up/cc0uw58CXExv9qcXJ9/tMFD90N/G0FUlokdR32V Qyr+GPGd+c0xcPfMKP/7ToyCXIdx3gySZ8mVjJ6TcexUJ/bUoD9juxsP8QZzfkKv rIxHCenrziAhT6O/LX0LbH+iQ/ic44Vf9bbEmfXK9jmctfFX+fqC+zC0qI5WadBW 7ZzWvSlNZLqgXwr2Z9htHhugD2lEqbPBKVjviBmw7h5/WBDrmAR59uXuN7OzPD+E 50EY2LKLveaLzetRjGeX97TWpYqVWhYA== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=anholt.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); smime=temperror; spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=anholt.net header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=anholt.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); smime=temperror; spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=anholt.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933111AbeAYDad (ORCPT ); Wed, 24 Jan 2018 22:30:33 -0500 Received: from anholt.net ([50.246.234.109]:46760 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933094AbeAYDac (ORCPT ); Wed, 24 Jan 2018 22:30:32 -0500 From: Eric Anholt To: Sasha Levin , "linux-kernel\@vger.kernel.org" , "stable\@vger.kernel.org" Cc: Stefan Schake , Sasha Levin Subject: Re: [PATCH AUTOSEL for 4.14 001/100] drm/vc4: Account for interrupts in flight In-Reply-To: <20180124041414.32065-1-alexander.levin@microsoft.com> References: <20180124041414.32065-1-alexander.levin@microsoft.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Thu, 25 Jan 2018 14:30:23 +1100 Message-ID: <87lggmpqcw.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Sasha Levin writes: > From: Stefan Schake > > [ Upstream commit 253696ccd613fbdaa5aba1de44c461a058e0a114 ] > > Synchronously disable the IRQ to make the following cancel_work_sync > invocation effective. > > An interrupt in flight could enqueue further overflow mem work. As we > free the binner BO immediately following vc4_irq_uninstall this caused > a NULL pointer dereference in the work callback vc4_overflow_mem_work. > > Link: https://github.com/anholt/linux/issues/114 > Signed-off-by: Stefan Schake > Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.") > Signed-off-by: Eric Anholt > Reviewed-by: Eric Anholt > Link: https://patchwork.freedesktop.org/patch/msgid/1510275907-993-2-git-= send-email-stschake@gmail.com > Signed-off-by: Sasha Levin We found a bug, and this patch also needs: commit ce9caf2f79a5aa170a4b6456a03db639eed9c988 (tag: drm-misc-fixes-2018-0= 1-08) Author: Stefan Schake Date: Fri Dec 29 17:05:43 2017 +0100 drm/vc4: Move IRQ enable to PM path =20=20=20=20 We were calling enable_irq on bind, where it was already enabled previo= usly by the IRQ helper. Additionally, dev->irq is not set correctly until af= ter postinstall and so was always zero here, triggering a warning in 4.15. Fix both by moving the enable to the power management resume path, wher= e we know there was a previous disable invocation during suspend. =20=20=20=20 Fixes: 253696ccd613 ("drm/vc4: Account for interrupts in flight") Signed-off-by: Stefan Schake Signed-off-by: Eric Anholt Link: https://patchwork.freedesktop.org/patch/msgid/1514563543-32511-1-= git-send-email-stschake@gmail.com Tested-by: Stefan Wahren Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlppT08ACgkQtdYpNtH8 nug8Qg/6AxCiYlnBknJeh8uCKRWvM9qFUIXBtZoL/PdvhPGxb5yXCLYIfwoFpMlk agOBV2ag9Ni2Fpiyi1rub7nox+pXWfS8Z0pSS2c/O26gnIsDWB9L2NmZ8/2YxnQw z3qZQ8bBtvVmGDoBJjV4odo2Qpwbh8zUvcC4WDiePoE/UgS/YvW/K0cawj585drZ eGXTzGXnLlptQwzOZoZINONlJHIqUi1nCD1vK//snKGDvnWFn4chcKycv38dvxja Q6xYdR9rXTmPp5rQCJIgBf3wVKuwhMI3cfuUO7loexkD5P9giYL6IUY91xbyE87j yy0DPfj+fsOKTGWEINb8SSIeq+oVanQh0+vw7mDdYyfTxVtXtTvLV7fSkMThNXDA PJqDar2QT4yR7Y0q7Wso0jMo71GYRH8TDukBcGzYNQlOMVuoPkw3xZtOp+61w6t9 MDGIhSTkFufOakEUC6Bh1BAGMFrPPpWjMqRBB0JegriU3INgbCiTpDRvZaoaY5kA ImyQqeL8gJfA6/zOO2aEhOYAt6wv5MjGsaWn+XBCS+fq6Plrx4oHX3lPjnXON6ku y/wtp+Ly7OufLelyGC22GE8bckrDEGXleqb0HN3pm7l5geA8TQ3Yv/P4/f+PrIhx mozqPWeHZYXLRnU9zfA09Y2wI68jDdFA+uw7E2FOwcjffMPWpXY= =/pej -----END PGP SIGNATURE----- --=-=-=--