public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	John Youn <johnyoun@synopsys.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	"open list\:ARM\/Rockchip SoC..." 
	<linux-rockchip@lists.infradead.org>,
	Julius Werner <jwerner@chromium.org>,
	Eric Anholt <eric@anholt.net>,
	linux-kernel@vger.kernel.org,
	John Stultz <john.stultz@linaro.org>,
	linux-usb@vger.kernel.org, Johan Hovold <johan@kernel.org>,
	Alexandru M Stan <amstan@chromium.org>,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away
Date: Tue, 31 Oct 2017 12:22:36 +0200	[thread overview]
Message-ID: <87lgjrd3bn.fsf@linux.intel.com> (raw)
In-Reply-To: <CAD=FV=UsYccsvicnce8wDpt3LaLQE23wdc7a4-m7OOhNS2JKgA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

Doug Anderson <dianders@chromium.org> writes:

> Hi,
>
> On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <balbi@kernel.org> wrote:
>>
>> Hi,
>>
>> Doug Anderson <dianders@chromium.org> writes:
>>> Hi,
>>>
>>> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>>>> Hi Doug,
>>>>
>>>> [add Felipe since this should go through his tree]
>>>
>>> Ah.  Sorry Felipe!  I know you've landed some dwc2 stuff in the past
>>
>> No problems :-)
>>
>>> but for some reason get_maintainer didn't ID you so I thought maybe
>>> you weren't doing it anymore.  Please let me know if you'd like me to
>>> send this to you again with collected Reviewed-by and Tested-by tags.
>>
>> Yeah, please resend with all tags collected, however let's wait for a
>> week or so and give other people time to catch up. I already sent my
>> pull request to Greg, this would, anyway, go into the -rc cycle.
>
> Doh!  I just re-read this one more time (after sending v3) and
> realized I had read it incorrectly.  I read it as "please send the

that's okay :-) s**t happens

> patch with the tags and I'll wait a week before landing", but you
> actually said "please wait a week before re-sending".  Sorry for the
> noise.  In the very least, you should be on the "To" line now so if
> anyone else has any extra tags it should be very easy for you to see
> them.
>
> Right that there's no massive urgency.  It's been broken forever.

alright then :-)

>> Please add a Cc stable tag too, if necessary.
>
> Good point.  It's a little weird since it doesn't "fix" any specific
> commit, so I guess it will be up to stable folks to decide how far to
> go back.  The dwc2 devices I work with are actually on 3.14, but we
> have some pretty massive backports related to dwc2 there...

fair enough

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-10-31 10:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 20:22 [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away Douglas Anderson
2017-10-28 15:51 ` Stefan Wahren
2017-10-29 20:07   ` Doug Anderson
2017-10-30  8:32     ` Felipe Balbi
2017-10-30 17:14       ` Doug Anderson
2017-10-31 10:22         ` Felipe Balbi [this message]
     [not found]         ` <1555993677.606646.1511879848977@email.1und1.de>
2017-11-28 16:07           ` Doug Anderson
  -- strict thread matches above, loose matches on Subject: below --
2017-11-12  5:08 Alyssa Rosenzweig
2017-11-14 19:49 ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgjrd3bn.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=amstan@chromium.org \
    --cc=dianders@chromium.org \
    --cc=eric@anholt.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=john.stultz@linaro.org \
    --cc=johnyoun@synopsys.com \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox