From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Jürg Billeter" <j@bitron.ch>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Oleg Nesterov" <oleg@redhat.com>,
"Michael Kerrisk" <mtk.manpages@gmail.com>,
"Filipe Brandenburger" <filbranden@google.com>,
"David Wilcox" <davidvsthegiant@gmail.com>,
hansecke@gmail.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC
Date: Tue, 03 Oct 2017 15:32:54 -0500 [thread overview]
Message-ID: <87lgks7z0p.fsf@xmission.com> (raw)
In-Reply-To: <CA+55aFwnx9rY435UT4qiYMWyL++DL2tVaeph-syrkVUrUCW=Xg@mail.gmail.com> (Linus Torvalds's message of "Tue, 3 Oct 2017 13:02:00 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Tue, Oct 3, 2017 at 12:30 PM, Eric W. Biederman
> <ebiederm@xmission.com> wrote:
>>
>> We never signal the orignal parent. We signal the child that
>> requested the pdeath_signal when the original parent dies.
>
> Yeah, I keep making that mistake, because I always confuse this with
> the exit_signal handling.
>
> Just mentally kick me next time I do that: "Christ, Linus, not
> *again*! Take your damn meds"
>
> Anyway, it's more the "another confusing and fragile special case that
> will probably not be used very widely and cause confusion because it
> lacks any test coverage" thing I worry about most.
Agreed. That makes a more general solution perferable.
Eric
next prev parent reply other threads:[~2017-10-03 20:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 9:40 [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC Jürg Billeter
2017-09-12 17:05 ` Oleg Nesterov
2017-09-12 18:54 ` Jürg Billeter
2017-09-13 17:11 ` Oleg Nesterov
2017-09-13 17:26 ` Jürg Billeter
2017-09-13 17:48 ` Oleg Nesterov
2017-09-29 12:30 ` [RESEND PATCH] " Jürg Billeter
2017-10-02 23:20 ` Andrew Morton
2017-10-03 3:25 ` Eric W. Biederman
2017-10-03 6:45 ` Jürg Billeter
2017-10-03 14:46 ` Eric W. Biederman
2017-10-03 16:10 ` Linus Torvalds
2017-10-03 16:36 ` Eric W. Biederman
2017-10-03 17:02 ` Linus Torvalds
2017-10-03 19:30 ` Eric W. Biederman
2017-10-03 20:02 ` Linus Torvalds
2017-10-03 20:32 ` Eric W. Biederman [this message]
2017-10-03 17:00 ` Jürg Billeter
2017-10-03 17:40 ` Eric W. Biederman
2017-10-03 17:47 ` Jürg Billeter
2017-10-03 19:05 ` Eric W. Biederman
2017-10-05 16:27 ` Oleg Nesterov
2017-10-08 17:47 ` Jürg Billeter
2017-10-09 16:32 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgks7z0p.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=davidvsthegiant@gmail.com \
--cc=filbranden@google.com \
--cc=hansecke@gmail.com \
--cc=j@bitron.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox