From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbdHRHW5 (ORCPT ); Fri, 18 Aug 2017 03:22:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:38198 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbdHRHW4 (ORCPT ); Fri, 18 Aug 2017 03:22:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,391,1498546800"; d="asc'?scan'208";a="141154331" From: Felipe Balbi To: Kai-Heng Feng , mathias.nyman@intel.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kai-Heng Feng Subject: Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk In-Reply-To: <20170818042050.1728-1-kai.heng.feng@canonical.com> References: <20170818042050.1728-1-kai.heng.feng@canonical.com> Date: Fri, 18 Aug 2017 10:22:41 +0300 Message-ID: <87lgmhqr0e.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable hi, Kai-Heng Feng writes: > When plugging Logitech C920 webcam, warning messages filled up dmesg: > [77117.655018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short= TX: needs XHCI_TRUST_TX_LENGTH quirk? > [77117.659018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short= TX: needs XHCI_TRUST_TX_LENGTH quirk? have you confirmed this is needed for this controller? Anybody from Renesas has confirmed it? Do you have an errata document to refer to? > [77122.622952] handle_tx_event: 541 callbacks suppressed > > No more warning messages with XHCI_TRUST_TX_LENGTH applied. > > BugLink: https://bugs.launchpad.net/bugs/1710548 > Signed-off-by: Kai-Heng Feng > --- > drivers/usb/host/xhci-pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index 8071c8fdd15e..8566b43e19ba 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -202,8 +202,10 @@ static void xhci_pci_quirks(struct device *dev, stru= ct xhci_hcd *xhci) > xhci->quirks |=3D XHCI_BROKEN_STREAMS; > } > if (pdev->vendor =3D=3D PCI_VENDOR_ID_RENESAS && > - pdev->device =3D=3D 0x0015) > + pdev->device =3D=3D 0x0015) { unnecessary > xhci->quirks |=3D XHCI_RESET_ON_RESUME; > + xhci->quirks |=3D XHCI_TRUST_TX_LENGTH; xhci->quirks |=3D XHCI_RESET_ON_RESUME | XHCI_TRUST_TX_LENGTH; > + } unnecessary =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlmWlcMACgkQzL64meEa mQaY3Q/9G+NiHRRGlRzw2z7/j1ZB2ZuBWoxX3LaCmI+gVF2na/vY3XpG69hUJrsZ CXZVAyNsOJWjQ3iRecV59lgwbDlEUiuo/sXo6T8/5QCTyqwpOeCg+E0MPBfdgvjW e3MQkJXwl1FXUFme3/G9GQs3Y20C5LqMP2Nz1p8UR7rhGI78otM2sn9ZKD7mE2QH iFzdh8NJa4H57F1FieqIBTkOQpEXs/F+t9juZDCpNdnbAn0PiYy+ZN5MLaED2MRj FmUpH2ttsuQ38E37A9BxGYo0qeP+wI5zrDVXacZiw8f5lQ0/078To4h0huy7Ef3l wrwyt44brmOWmejXS+bRNpYxlQTHUTJuFQJGdbun3pHT+hj6CpSUjly7/iCBo9+t XkhLS6Bw1IPOSyp2cLE+jwZpGscPa9qrJq4yHfZU7Mu5cyqFkI4+shYJ8saIJ0Xj /qPstfEH1biVdhxcfKAPrMIHFjlHoEKdyAg6Wh07Samq9KdN86t7w7w8omhtYGSl brb8Bai1R2PTDn8nxlF0scEW4w1n+8CY9LgsEHlfopznc/vT+GUtjJ9GwHgO/daY y2zvRGcmO9iiOYZXDpXdHKyRJ3tcX3BVp7wmd42n94exxRzrVNltxivAhDDp74pn 0ECkDOhWhYuawS7aYii/nv088sNaLZpaVj4BlIJ9MiTmflBiGFI= =hkns -----END PGP SIGNATURE----- --=-=-=--