The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Huang\, Ying" <ying.huang@intel.com>
To: Byungchul Park <byungchul.park@lge.com>
Cc: <peterz@infradead.org>, <mingo@kernel.org>,
	<koverstreet@google.com>, <neilb@suse.de>, <nab@linux-iscsi.org>,
	<viro@zeniv.linux.org.uk>, <ying.huang@intel.com>,
	<oleg@redhat.com>, <asias@redhat.com>, <shli@kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] llist: Don't reinvent the wheel but use existing llist API
Date: Mon, 13 Feb 2017 13:38:36 +0800	[thread overview]
Message-ID: <87lgtatztv.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <1486959013-26105-1-git-send-email-byungchul.park@lge.com> (Byungchul Park's message of "Mon, 13 Feb 2017 13:10:13 +0900")

Hi, Byungchul,

Byungchul Park <byungchul.park@lge.com> writes:

> Although llist provides proper APIs, they are not used. Make them used.
>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  drivers/md/bcache/closure.c | 15 ++-------------
>  drivers/md/raid5.c          |  4 +---
>  drivers/vhost/scsi.c        |  9 ++-------
>  fs/file_table.c             | 12 +++++-------
>  fs/namespace.c              | 12 +++++-------
>  include/linux/llist.h       |  3 +++
>  kernel/irq_work.c           |  6 +-----
>  kernel/sched/core.c         | 13 ++-----------
>  mm/vmalloc.c                |  8 +++-----

I think you need to split the patch.  One for each subsystem, this makes
it easier to be reviewed and merged.

Best Regards,
Huang, Ying

[snip]

  parent reply	other threads:[~2017-02-13  5:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13  4:10 [PATCH] llist: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-02-13  4:56 ` NeilBrown
2017-02-13  5:14   ` Byungchul Park
2017-02-13  5:38 ` Huang, Ying [this message]
2017-02-13  5:55   ` Byungchul Park
2017-02-13  5:43 ` Al Viro
2017-02-13  6:00   ` Byungchul Park
2017-02-24  1:20 ` [lkp-robot] [llist] bc1a405b00: Kernel_panic-not_syncing:No_working_init_found kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgtatztv.fsf@yhuang-dev.intel.com \
    --to=ying.huang@intel.com \
    --cc=asias@redhat.com \
    --cc=byungchul.park@lge.com \
    --cc=koverstreet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=neilb@suse.de \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shli@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox