From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbdBFKMY convert rfc822-to-8bit (ORCPT ); Mon, 6 Feb 2017 05:12:24 -0500 Received: from mga03.intel.com ([134.134.136.65]:10822 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbdBFKMX (ORCPT ); Mon, 6 Feb 2017 05:12:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,341,1477983600"; d="scan'208";a="817544335" From: Jani Nikula To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Cc: thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/7] drm: Add DRM support for tiny LCD displays In-Reply-To: <20170131160319.9695-2-noralf@tronnes.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170131160319.9695-1-noralf@tronnes.org> <20170131160319.9695-2-noralf@tronnes.org> Date: Mon, 06 Feb 2017 12:12:05 +0200 Message-ID: <87lgtjbpca.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Jan 2017, Noralf Trønnes wrote: > +const struct file_operations tinydrm_fops = { > + .owner = THIS_MODULE, > + .open = drm_open, > + .release = drm_release, > + .unlocked_ioctl = drm_ioctl, > +#ifdef CONFIG_COMPAT > + .compat_ioctl = drm_compat_ioctl, > +#endif No need for the ifdefs, drm_compat_ioctl will be defined NULL for CONFIG_COMPAT=n. BR, Jani. > + .poll = drm_poll, > + .read = drm_read, > + .llseek = no_llseek, > + .mmap = drm_gem_cma_mmap, > +}; > +EXPORT_SYMBOL(tinydrm_fops); -- Jani Nikula, Intel Open Source Technology Center