From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
John Youn <johnyoun@synopsys.com>,
Vardan Mikayelyan <mvardan@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param
Date: Tue, 22 Nov 2016 14:23:04 +0200 [thread overview]
Message-ID: <87lgwbr9ef.fsf@linux.intel.com> (raw)
In-Reply-To: <1479677166-13114-6-git-send-email-stefan.wahren@i2se.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
Hi,
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Since there is no parameter @value replace it with @legacy.
>
> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/usb/dwc2/params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 11fe68a..10407cb 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -320,7 +320,7 @@ static void dwc2_set_core_param(void *param, u8 size, u64 value)
> * @size: The size of the core parameter in bytes, or 0 for bool.
> *
> * This function looks up @property and sets the @param to that value.
> - * If the property doesn't exist it uses the passed-in @value. It will
> + * If the property doesn't exist it uses the passed-in @legacy value. It will
This doesn't fix any bugs. Also, is @legacy a parameter?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2016-11-22 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 21:26 [PATCH 0/5] usb: dwc2: fix parameter handling Stefan Wahren
2016-11-20 21:26 ` [PATCH 1/5] usb: dwc2: Do not set host parameter in peripheral mode Stefan Wahren
2016-11-20 21:26 ` [PATCH 2/5] usb: dwc2: fix dwc2_get_device_property for u8 and u16 Stefan Wahren
2016-11-20 21:26 ` [PATCH 3/5] usb: dwc2: fix default value for DMA support Stefan Wahren
2016-11-20 21:26 ` [PATCH 4/5] usb: dwc2: gadget: fix default value for gadget-dma-desc Stefan Wahren
2016-11-20 21:26 ` [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param Stefan Wahren
2016-11-22 12:23 ` Felipe Balbi [this message]
2016-11-22 13:57 ` Stefan Wahren
2016-11-22 13:59 ` Felipe Balbi
2016-11-21 23:45 ` [PATCH 0/5] usb: dwc2: fix parameter handling John Youn
2016-11-22 12:04 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgwbr9ef.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnyoun@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mvardan@synopsys.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox