From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932630AbcA3RFs (ORCPT ); Sat, 30 Jan 2016 12:05:48 -0500 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:61739 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbcA3RFq (ORCPT ); Sat, 30 Jan 2016 12:05:46 -0500 Date: Sun, 31 Jan 2016 02:05:43 +0900 Message-ID: <87lh77ro9k.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Stephen Boyd Cc: Rich Felker , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [RFC/PATCH] sh: Use generic clkdev.h header In-Reply-To: <1453937814-17819-1-git-send-email-sboyd@codeaurora.org> References: <1453937814-17819-1-git-send-email-sboyd@codeaurora.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Jan 2016 08:36:54 +0900, Stephen Boyd wrote: > > The generic header file is almost equivalent to the SH one. The > only difference is that the SH one supports allocating clkdev > lookups early using bootmem allocators instead of the slabs. From > what I can tell using visual inspection, the slab is initialized > before any clkdev allocation is made under arch/sh. So let's > remove the arch specific clkdev.h header and use the generic one > instead. OK. Works fine. Applied later. Thanks. > Signed-off-by: Stephen Boyd > --- > > Not even compile tested, but done with visual inspection. > > arch/sh/include/asm/Kbuild | 1 + > arch/sh/include/asm/clkdev.h | 33 --------------------------------- > 2 files changed, 1 insertion(+), 33 deletions(-) > delete mode 100644 arch/sh/include/asm/clkdev.h > > diff --git a/arch/sh/include/asm/Kbuild b/arch/sh/include/asm/Kbuild > index aac452b26aa8..a319745a7b63 100644 > --- a/arch/sh/include/asm/Kbuild > +++ b/arch/sh/include/asm/Kbuild > @@ -1,5 +1,6 @@ > > generic-y += bitsperlong.h > +generic-y += clkdev.h > generic-y += cputime.h > generic-y += current.h > generic-y += delay.h > diff --git a/arch/sh/include/asm/clkdev.h b/arch/sh/include/asm/clkdev.h > deleted file mode 100644 > index c41901465fb0..000000000000 > --- a/arch/sh/include/asm/clkdev.h > +++ /dev/null > @@ -1,33 +0,0 @@ > -/* > - * Copyright (C) 2010 Paul Mundt > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * Helper for the clk API to assist looking up a struct clk. > - */ > - > -#ifndef __CLKDEV__H_ > -#define __CLKDEV__H_ > - > -#include > -#include > -#include > - > -#include > - > -static inline struct clk_lookup_alloc *__clkdev_alloc(size_t size) > -{ > - if (!slab_is_available()) > - return alloc_bootmem_low_pages(size); > - else > - return kzalloc(size, GFP_KERNEL); > -} > - > -#ifndef CONFIG_COMMON_CLK > -#define __clk_put(clk) > -#define __clk_get(clk) ({ 1; }) > -#endif > - > -#endif /* __CLKDEV_H__ */ > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Yoshinori Sato