Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]


Hi,

LABBE Corentin <clabbe.montjoie@gmail.com> writes:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later. Renaming id to of_id (like all others do) in the
> process.
>
> Reported-by: coverity (CID 1324133)
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
>  drivers/usb/phy/phy-msm-usb.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index 80eb991..c4a66cf 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1506,20 +1506,23 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
>  {
>  	struct msm_otg_platform_data *pdata;
>  	struct extcon_dev *ext_id, *ext_vbus;
> -	const struct of_device_id *id;
> +	const struct of_device_id *of_id;

and why did you need to rename this variable ? Please resend without the
variable rename.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]