From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751332AbbIBGRP (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Sep 2015 02:17:15 -0400
Received: from ozlabs.org ([103.22.144.67]:49050 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750776AbbIBGRO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Sep 2015 02:17:14 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: timing of module MODULE_STATE_COMING notifier
In-Reply-To: <20150831204017.GI29756@redhat.com>
References: <20150831000642.GG29756@redhat.com> <87si70p7c9.fsf@rustcorp.com.au> <20150831125326.GH29756@redhat.com> <20150831204017.GI29756@redhat.com>
User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu)
Date: Wed, 02 Sep 2015 15:32:58 +0930
Message-ID: <87lhcp1hpp.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

"Frank Ch. Eigler" <fche@redhat.com> writes:
> Hi, Rusty -
>
>
> I wrote:
>
>> [...]
>> > Notifiers suck for stuff like this :( Module state has many steps,
>> > so my preference has been to open-code explicit hooks.  [...]
>> 
>> You mean something like the trace_module_load()?  (We will probably
>> experiment with hooking into that tracepoint instead of the notifier.)
>> [...]
>
> It turns out this works OK, except for EXPORT_TRACEPOINT_SYMBOL_GPL.
> Could we get a set of EXPORT_TRACEPOINT_SYMBOL_GPL's for the
> trace/events/module.h tracepoints (at least module_load and
> module_free)?

Sure, patch welcome.

Cheers,
Rusty.