From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org,
David Herrmann <dh.herrmann@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"open list\:ABI\/API" <linux-api@vger.kernel.org>,
Denys Vlasenko <dvlasenk@redhat.com>
Subject: Re: [PATCH v5] Add virtio-input driver.
Date: Fri, 27 Mar 2015 13:26:29 +1030 [thread overview]
Message-ID: <87lhijqhb6.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20150326130644-mutt-send-email-mst@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Mar 26, 2015 at 11:49:25AM +0100, Gerd Hoffmann wrote:
>> virtio-input is basically evdev-events-over-virtio, so this driver isn't
>> much more than reading configuration from config space and forwarding
>> incoming events to the linux input layer.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Still a bit worried about using input.h as host/guest
> interface (can't we use some formal standard, e.g. USB HID?),
> but I'll let Rusty decide that.
I like the simplicity, and this API is pretty well proven.
Since this is under drivers/virtio rather than drivers/input, I've
applied it to my tree.
I have a dream where Denys Vlasenko adds this and the virtio gl device
to lguest, and we have X running under lguest :)
Applied!
Rusty.
next prev parent reply other threads:[~2015-03-27 3:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 10:49 [PATCH v5] Add virtio-input driver Gerd Hoffmann
2015-03-26 12:10 ` Michael S. Tsirkin
2015-03-27 2:56 ` Rusty Russell [this message]
2015-03-28 19:07 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhijqhb6.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dh.herrmann@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox