From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbbC0DNP (ORCPT ); Thu, 26 Mar 2015 23:13:15 -0400 Received: from ozlabs.org ([103.22.144.67]:57709 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914AbbC0DNM (ORCPT ); Thu, 26 Mar 2015 23:13:12 -0400 From: Rusty Russell To: "Michael S. Tsirkin" , Gerd Hoffmann Cc: virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, David Herrmann , Dmitry Torokhov , open list , "open list\:ABI\/API" , Denys Vlasenko Subject: Re: [PATCH v5] Add virtio-input driver. In-Reply-To: <20150326130644-mutt-send-email-mst@redhat.com> References: <1427366965-32549-1-git-send-email-kraxel@redhat.com> <20150326130644-mutt-send-email-mst@redhat.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Fri, 27 Mar 2015 13:26:29 +1030 Message-ID: <87lhijqhb6.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Michael S. Tsirkin" writes: > On Thu, Mar 26, 2015 at 11:49:25AM +0100, Gerd Hoffmann wrote: >> virtio-input is basically evdev-events-over-virtio, so this driver isn't >> much more than reading configuration from config space and forwarding >> incoming events to the linux input layer. >> >> Signed-off-by: Gerd Hoffmann > > Still a bit worried about using input.h as host/guest > interface (can't we use some formal standard, e.g. USB HID?), > but I'll let Rusty decide that. I like the simplicity, and this API is pretty well proven. Since this is under drivers/virtio rather than drivers/input, I've applied it to my tree. I have a dream where Denys Vlasenko adds this and the virtio gl device to lguest, and we have X running under lguest :) Applied! Rusty.