public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Mathias Krause <minipli@googlemail.com>
Cc: linux-kernel@vger.kernel.org, Mathias Krause <minipli@googlemail.com>
Subject: Re: [PATCH 1/2] modpost: reduce visibility of symbols and constify r/o arrays
Date: Wed, 27 Aug 2014 20:29:21 +0930	[thread overview]
Message-ID: <87lhqa8agm.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1408962316-19921-2-git-send-email-minipli@googlemail.com>

Mathias Krause <minipli@googlemail.com> writes:
> Internally used symbols of modpost don't need to be externally visible;
> make them static. Also constify the string arrays so they resist in the
> r/o section instead of being runtime writable.

I'm not convinced of the second patch, but I've applied it anyway.

Thanks,
Rusty.

  reply	other threads:[~2014-08-27 11:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 10:25 [PATCH 0/2] modpost: small size reduction Mathias Krause
2014-08-25 10:25 ` [PATCH 1/2] modpost: reduce visibility of symbols and constify r/o arrays Mathias Krause
2014-08-27 10:59   ` Rusty Russell [this message]
2014-08-25 10:25 ` [PATCH 2/2] modpost: simplify file name generation of *.mod.c files Mathias Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhqa8agm.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minipli@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox