public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>, Frank Swiderski <fes@google.com>
Cc: riel@redhat.com, Andrea Arcangeli <aarcange@redhat.com>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	mikew@google.com
Subject: Re: [PATCH] Add a page cache-backed balloon device driver.
Date: Wed, 27 Jun 2012 12:26:55 +0930	[thread overview]
Message-ID: <87lij91myw.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120626214106.GC14054@redhat.com>

On Wed, 27 Jun 2012 00:41:06 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Jun 26, 2012 at 01:32:58PM -0700, Frank Swiderski wrote:
> > This implementation of a virtio balloon driver uses the page cache to
> > "store" pages that have been released to the host.  The communication
> > (outside of target counts) is one way--the guest notifies the host when
> > it adds a page to the page cache, allowing the host to madvise(2) with
> > MADV_DONTNEED.  Reclaim in the guest is therefore automatic and implicit
> > (via the regular page reclaim).  This means that inflating the balloon
> > is similar to the existing balloon mechanism, but the deflate is
> > different--it re-uses existing Linux kernel functionality to
> > automatically reclaim.
> > 
> > Signed-off-by: Frank Swiderski <fes@google.com>
> 
> I'm pondering this:
> 
> Should it really be a separate driver/device ID?
> If it behaves the same from host POV, maybe it
> should be up to the guest how to inflate/deflate
> the balloon internally?

Well, it shouldn't steal ID 10, either way :)  Either use a completely
bogus number, or ask for an id.

But AFAICT this should be a an alternate driver of for the same device:
it's not really a separate device, is it?

Cheers,
Rusty.

  reply	other threads:[~2012-06-27  9:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 20:32 [PATCH] Add a page cache-backed balloon device driver Frank Swiderski
2012-06-26 20:40 ` Rik van Riel
2012-06-26 21:31   ` Frank Swiderski
2012-06-26 21:45     ` Rik van Riel
2012-06-26 23:45       ` Frank Swiderski
2012-06-27  9:04         ` Michael S. Tsirkin
2012-06-26 21:47     ` Michael S. Tsirkin
2012-06-26 23:21       ` Frank Swiderski
2012-06-27  9:02         ` Michael S. Tsirkin
2012-07-02  0:29         ` Rusty Russell
2012-09-03  6:35           ` Paolo Bonzini
2012-09-06  1:35             ` Rusty Russell
2012-06-26 21:41 ` Michael S. Tsirkin
2012-06-27  2:56   ` Rusty Russell [this message]
2012-06-27 15:48     ` Frank Swiderski
2012-06-27 16:06       ` Michael S. Tsirkin
2012-06-27 16:08         ` Frank Swiderski
2012-06-27  9:40 ` Amit Shah
2012-08-30  8:57 ` Michael S. Tsirkin
2012-09-03 15:09 ` Avi Kivity
2012-09-10  9:05 ` Michael S. Tsirkin
2012-09-10 17:37   ` Mike Waychison
2012-09-10 18:04     ` Rik van Riel
2012-09-10 18:29       ` Mike Waychison
2012-09-10 19:59     ` Michael S. Tsirkin
2012-09-10 20:49       ` Mike Waychison
2012-09-10 21:10         ` Michael S. Tsirkin
2012-10-30 15:29           ` Michael S. Tsirkin
2012-10-30 16:25             ` Mike Waychison
2012-09-12  5:25         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lij91myw.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=aarcange@redhat.com \
    --cc=fes@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mst@redhat.com \
    --cc=riel@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox