* [Patch 0/1] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
@ 2012-04-11 18:39 Manoj Iyer
2012-04-11 18:39 ` [PATCH] " Manoj Iyer
0 siblings, 1 reply; 8+ messages in thread
From: Manoj Iyer @ 2012-04-11 18:39 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-bluetooth, Johan Hedberg, Marcel Holtmann
Please consider this patch to add vendor specific ID
for BCM20702A0. Reported/Tested by Dennis Chua <dennis.chua@canonical.com>
on a Lenovo system.
root@u-k29-814ti006g:~# hcitool dev
Devices:
hci0 E4:D5:3D:F1:55:84
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
2012-04-11 18:39 [Patch 0/1] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0 Manoj Iyer
@ 2012-04-11 18:39 ` Manoj Iyer
2012-04-13 21:48 ` Gustavo Padovan
0 siblings, 1 reply; 8+ messages in thread
From: Manoj Iyer @ 2012-04-11 18:39 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-bluetooth, Johan Hedberg, Marcel Holtmann
usb-devices:
T: Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#= 4 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0a5c ProdID=21f4 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=E4D53DF15584
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Reported-by: Dennis Chua <dennis.chua@canonical.com>
Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
drivers/bluetooth/btusb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 480cad9..4ef79d0 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -104,6 +104,7 @@ static struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x0a5c, 0x21e3) },
{ USB_DEVICE(0x0a5c, 0x21e6) },
{ USB_DEVICE(0x0a5c, 0x21f3) },
+ { USB_DEVICE(0x0a5c, 0x21f4) },
{ USB_DEVICE(0x413c, 0x8197) },
{ } /* Terminating entry */
--
1.7.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
2012-04-11 18:39 ` [PATCH] " Manoj Iyer
@ 2012-04-13 21:48 ` Gustavo Padovan
2012-06-08 14:19 ` Luis Henriques
2012-07-06 17:14 ` Manoj Iyer
0 siblings, 2 replies; 8+ messages in thread
From: Gustavo Padovan @ 2012-04-13 21:48 UTC (permalink / raw)
To: Manoj Iyer; +Cc: linux-kernel, linux-bluetooth, Johan Hedberg, Marcel Holtmann
Hi Manoj,
* Manoj Iyer <manoj.iyer@canonical.com> [2012-04-11 13:39:23 -0500]:
> usb-devices:
> T: Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#= 4 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=0a5c ProdID=21f4 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=E4D53DF15584
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
You need to give the usb-devices for the non-working case. I know it
works but we need to document this right in the commit message.
Gustavo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
2012-04-13 21:48 ` Gustavo Padovan
@ 2012-06-08 14:19 ` Luis Henriques
2012-07-06 17:14 ` Manoj Iyer
1 sibling, 0 replies; 8+ messages in thread
From: Luis Henriques @ 2012-06-08 14:19 UTC (permalink / raw)
To: Gustavo Padovan
Cc: Manoj Iyer, linux-kernel, linux-bluetooth, Johan Hedberg,
Marcel Holtmann
Hi Gustavo,
Gustavo Padovan <gustavo@padovan.org> writes:
> Hi Manoj,
>
> * Manoj Iyer <manoj.iyer@canonical.com> [2012-04-11 13:39:23 -0500]:
>
>> usb-devices:
>> T: Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#= 4 Spd=12 MxCh= 0
>> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=0a5c ProdID=21f4 Rev=01.12
>> S: Manufacturer=Broadcom Corp
>> S: Product=BCM20702A0
>> S: SerialNumber=E4D53DF15584
>> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
>> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
>> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> You need to give the usb-devices for the non-working case. I know it
> works but we need to document this right in the commit message.
I was wondering whether there has been any progress with this patch.
Is there something still pending?
I'll try to get the patch tested as we have a bug open to support this
hardware.
Cheers,
--
Luis
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
2012-04-13 21:48 ` Gustavo Padovan
2012-06-08 14:19 ` Luis Henriques
@ 2012-07-06 17:14 ` Manoj Iyer
2012-07-10 18:30 ` Gustavo Padovan
1 sibling, 1 reply; 8+ messages in thread
From: Manoj Iyer @ 2012-07-06 17:14 UTC (permalink / raw)
To: Gustavo Padovan
Cc: Manoj Iyer, linux-kernel, linux-bluetooth, Johan Hedberg,
Marcel Holtmann, Chris Gagnon
On Fri, 13 Apr 2012, Gustavo Padovan wrote:
Gustavo,
Sorry it took a long time to locate the hardware to get this info, I got
this info from one our QA engg cced here. Do you want me to resubmit the
patch ?
Before the patch
=================
T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0a5c ProdID=21f4 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=E4D53DF154D6
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
After the patch
================
T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0a5c ProdID=21f4 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=E4D53DF154D6
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
> Hi Manoj,
>
> * Manoj Iyer <manoj.iyer@canonical.com> [2012-04-11 13:39:23 -0500]:
>
>> usb-devices:
>> T: Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#= 4 Spd=12 MxCh= 0
>> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=0a5c ProdID=21f4 Rev=01.12
>> S: Manufacturer=Broadcom Corp
>> S: Product=BCM20702A0
>> S: SerialNumber=E4D53DF15584
>> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
>> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
>> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> You need to give the usb-devices for the non-working case. I know it
> works but we need to document this right in the commit message.
>
> Gustavo
>
>
--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
2012-07-06 17:14 ` Manoj Iyer
@ 2012-07-10 18:30 ` Gustavo Padovan
0 siblings, 0 replies; 8+ messages in thread
From: Gustavo Padovan @ 2012-07-10 18:30 UTC (permalink / raw)
To: Manoj Iyer
Cc: linux-kernel, linux-bluetooth, Johan Hedberg, Marcel Holtmann,
Chris Gagnon
Hi Manoj,
* Manoj Iyer <manoj.iyer@canonical.com> [2012-07-06 12:14:22 -0500]:
> On Fri, 13 Apr 2012, Gustavo Padovan wrote:
>
> Gustavo,
>
> Sorry it took a long time to locate the hardware to get this info, I
> got this info from one our QA engg cced here. Do you want me to
> resubmit the patch ?
Yes, please resend the patch with proper git format. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
@ 2012-07-10 19:07 manoj.iyer
2012-07-10 19:43 ` Gustavo Padovan
0 siblings, 1 reply; 8+ messages in thread
From: manoj.iyer @ 2012-07-10 19:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Gustavo Padovan, linux-bluetooth, Manoj Iyer
From: Manoj Iyer <manoj.iyer@canonical.com>
Patch adds support for BCM20702A0 device id (0a5c:21f4).
usb-devices after patch was applied:
T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0a5c ProdID=21f4 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=E4D53DF154D6
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
usb-devices before patch was applied:
T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0a5c ProdID=21f4 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=E4D53DF154D6
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
Tested-by: Chris Gagnon <chris.gagnon@canonical.com>
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 83ebb24..1ecb8e5 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -106,6 +106,7 @@ static struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x0a5c, 0x21e6) },
{ USB_DEVICE(0x0a5c, 0x21e8) },
{ USB_DEVICE(0x0a5c, 0x21f3) },
+ { USB_DEVICE(0x0a5c, 0x21f4) },
{ USB_DEVICE(0x413c, 0x8197) },
/* Foxconn - Hon Hai */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0
2012-07-10 19:07 manoj.iyer
@ 2012-07-10 19:43 ` Gustavo Padovan
0 siblings, 0 replies; 8+ messages in thread
From: Gustavo Padovan @ 2012-07-10 19:43 UTC (permalink / raw)
To: manoj.iyer; +Cc: linux-kernel, linux-bluetooth
Hi Manoj,
* manoj.iyer@canonical.com <manoj.iyer@canonical.com> [2012-07-10 14:07:38 -0500]:
> From: Manoj Iyer <manoj.iyer@canonical.com>
>
> Patch adds support for BCM20702A0 device id (0a5c:21f4).
>
> usb-devices after patch was applied:
> T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=0a5c ProdID=21f4 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=E4D53DF154D6
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> usb-devices before patch was applied:
> T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=0a5c ProdID=21f4 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=E4D53DF154D6
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> Tested-by: Chris Gagnon <chris.gagnon@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
Patch has been applied to the bluetooth tree. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-07-10 19:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-11 18:39 [Patch 0/1] Bluetooth: btusb: Add vendor specific ID (0a5c:21f4) BCM20702A0 Manoj Iyer
2012-04-11 18:39 ` [PATCH] " Manoj Iyer
2012-04-13 21:48 ` Gustavo Padovan
2012-06-08 14:19 ` Luis Henriques
2012-07-06 17:14 ` Manoj Iyer
2012-07-10 18:30 ` Gustavo Padovan
-- strict thread matches above, loose matches on Subject: below --
2012-07-10 19:07 manoj.iyer
2012-07-10 19:43 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox