From: Andi Kleen <andi@firstfloor.org>
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jbarnes@virtuousgeek.org
Subject: Re: [PATCH] Add support for turning PCIe ECRC on or off
Date: Fri, 03 Apr 2009 08:54:39 +0200 [thread overview]
Message-ID: <87ljqikz0w.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20090402221751.11757.36392.stgit@bob.kio> (Andrew Patterson's message of "Thu, 02 Apr 2009 16:17:51 -0600")
Andrew Patterson <andrew.patterson@hp.com> writes:
> Add support for turning PCIe ECRC on or off
>
> Adds support for PCI Express transaction layer end-to-end CRC checking
> (ECRC). This patch will enable/disable ECRC checking by setting/clearing
> the ECRC Check Enable and/or ECRC Generation Enable bits for devices that
> support ECRC.
>
> The ECRC setting is controlled by the "pcie_ecrc=" command-line option. If
> this option is not set or is set to 'default", the enable and generation
> bits are left in whatever state that firmware/BIOS sets them to. The
> "off" setting turns them off, and the "on" option turns them on (if the
> device supports it).
Can you please expand a little bit on your motvation? Why does the kernel
need to set that over the firmware? And why does it need to be a boot
parameter vs some sysfs file?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-04-03 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 22:17 [PATCH] Add support for turning PCIe ECRC on or off Andrew Patterson
2009-04-03 2:08 ` Kenji Kaneshige
2009-04-03 16:58 ` Andrew Patterson
2009-04-07 1:43 ` Kenji Kaneshige
2009-04-07 16:35 ` Andrew Patterson
2009-04-08 1:04 ` Kenji Kaneshige
2009-04-03 6:54 ` Andi Kleen [this message]
2009-04-03 19:47 ` Andrew Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljqikz0w.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=andrew.patterson@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox