public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Robert Richter <robert.richter@amd.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] OProfile fixes for v2.6.28
Date: Mon, 10 Nov 2008 09:43:05 +0100	[thread overview]
Message-ID: <87ljvsott2.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4917EB51.9020304@cosmosbay.com> (Eric Dumazet's message of "Mon, 10 Nov 2008 09:05:37 +0100")

Eric Dumazet <dada1@cosmosbay.com> writes:

> diff --git a/arch/x86/oprofile/op_model_ppro.c b/arch/x86/oprofile/op_model_ppro.c
> index 3f1b81a..716d26f 100644
> --- a/arch/x86/oprofile/op_model_ppro.c
> +++ b/arch/x86/oprofile/op_model_ppro.c
> @@ -69,7 +69,7 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs)
>  	int i;
>  
>  	if (!reset_value) {
> -		reset_value = kmalloc(sizeof(unsigned) * num_counters,
> +		reset_value = kmalloc(sizeof(reset_value[0]) * num_counters,

Thanks for tracking this down.

But that still doesn't explain why 2.6.27 fails too?

-Andi

-- 
ak@linux.intel.com

  reply	other threads:[~2008-11-10  8:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 17:13 [git pull] OProfile fixes for v2.6.28 Robert Richter
2008-11-07 18:22 ` Ingo Molnar
2008-11-10  8:05 ` Eric Dumazet
2008-11-10  8:43   ` Andi Kleen [this message]
2008-11-10  9:01     ` Eric Dumazet
2008-11-10 14:23     ` [PATCH] oprofile: re-arm APIC_DM_NMI in ppro_check_ctrs() Eric Dumazet
2008-11-10 15:49       ` Andi Kleen
2008-11-10 15:50         ` Eric Dumazet
2008-11-10 17:46           ` Andi Kleen
2008-11-11  8:32         ` Eric Dumazet
2008-11-17 17:33           ` Robert Richter
2008-11-17 18:25             ` Andi Kleen
2008-11-18  8:57               ` Robert Richter
2008-11-10 16:11       ` Cyrill Gorcunov
2008-11-10 16:19         ` Eric Dumazet
2008-11-10 16:31           ` Cyrill Gorcunov
2008-11-17 17:57   ` [git pull] OProfile fixes for v2.6.28 Robert Richter
  -- strict thread matches above, loose matches on Subject: below --
2008-11-23 11:06 Robert Richter
2008-11-23 11:18 ` Ingo Molnar
2008-12-03 17:16 Robert Richter
2008-12-03 17:53 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ljvsott2.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox