public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roger Leigh <rleigh@whinlatter.ukfsn.org>
To: linux-kernel@vger.kernel.org
Cc: Dennis Munsie <dmunsie@cecropia.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: radeonfb i2c regression post-2.6.18.
Date: Sun, 18 Nov 2007 21:58:26 +0000	[thread overview]
Message-ID: <87lk8vxlkt.fsf@hardknott.home> (raw)

[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]

Hi folks,

I'm using an Apple Cinema Display connected via DVI to an Apple Mac
Mini with Radeon 9200 graphics.  This used to work fine, but with
kernels >= 2.6.19, the monitor powers off as soon as the framebuffer
is initialised, making for a less than usable system.  I've tested
with 2.6.(19|2[012]), and I didn't see any related changes in 2.6.23.

The breakage occured in this commit:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7a45093b7caa9d3d5421274b4ba80fba5da17e19

Specifically, these lines:

-       /* Release the DDC lines when done or the Apple Cinema HD display
-        * will switch off
-        */
-       OUTREG(reg, INREG(reg) & ~(VGA_DDC_CLK_OUT_EN | VGA_DDC_DATA_OUT_EN));
-       (void)INREG(reg);
+       u8 *edid = fb_ddc_read(&rinfo->i2c[conn-1].adapter);

BenH later applied a fix:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4f71c5de19c27f2198105d3b26b398494d5c353b

but I'm not sure if this is related to the above, or was for a
separate problem.  Either way, the monitor is still getting powered
off.

Due to the code reorganisation when the i2c stuff got moved into the
generic fbmon.c, I'm not sure where the workaround needs putting back
(if indeed this is where the problem lies).

I'm booting with video=ofonly to get a working system;
video=radeonfb:1680x1050-32@60 (with or without the additional
parameters) always results in a dead monitor as soon as the
framebuffer is set up.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

             reply	other threads:[~2007-11-18 21:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-18 21:58 Roger Leigh [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-11-18 23:16 radeonfb i2c regression post-2.6.18 Benjamin Herrenschmidt
2007-11-21  9:42 ` Roger Leigh
2007-11-21 19:58   ` Benjamin Herrenschmidt
2007-11-21 20:13     ` Michael Buesch
2007-11-21 20:17       ` Benjamin Herrenschmidt
2007-11-21 23:56     ` Roger Leigh
2007-11-22  0:00       ` Benjamin Herrenschmidt
2007-11-23 16:00 ` Michael Buesch
2007-11-23 22:29   ` Jean Delvare
2007-11-24  1:11     ` Benjamin Herrenschmidt
2007-11-24  9:29       ` Jean Delvare
2007-11-24 14:18     ` Michael Buesch
2007-11-24 22:20       ` Jean Delvare
2007-11-24 22:25         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lk8vxlkt.fsf@hardknott.home \
    --to=rleigh@whinlatter.ukfsn.org \
    --cc=benh@kernel.crashing.org \
    --cc=dmunsie@cecropia.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox