public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Philippe Troin <phil@fifi.org>
To: <Ganesh_Borse@Dell.com>
Cc: <linux-kernel-owner@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: CDROMPLAYTRKIND ioctl causing server hang
Date: 27 Aug 2004 09:38:17 -0700	[thread overview]
Message-ID: <87llg0tu2u.fsf@ceramic.fifi.org> (raw)
In-Reply-To: <BBE1167D4F12C74681106630ADE282B964A025@blrx2kmbgl303.blr.amer.dell.com>

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

<Ganesh_Borse@Dell.com> writes:

> (4) Is there a known issue in 2.4.21-4 kernel related to
> CDROMPLAYTRKIND ioctl or usb driver? If yes, what is Bugzilla id for
> it?

This patch does it for me, but of course it's a ugly hack...

Phil.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: linux-2.4.27-2-scsicdrom.patch --]
[-- Type: text/x-patch, Size: 1073 bytes --]

diff -ruN linux-2.4.27.orig/drivers/scsi/sr.c linux-2.4.27/drivers/scsi/sr.c
--- linux-2.4.27.orig/drivers/scsi/sr.c	Fri Jun 13 07:51:36 2003
+++ linux-2.4.27/drivers/scsi/sr.c	Mon Aug  9 15:34:08 2004
@@ -59,7 +59,7 @@
 MODULE_PARM(xa_test, "i");	/* see sr_ioctl.c */
 
 #define MAX_RETRIES	3
-#define SR_TIMEOUT	(30 * HZ)
+#define SR_TIMEOUT	(180 * HZ)
 
 static int sr_init(void);
 static void sr_finish(void);
diff -ruN linux-2.4.27.orig/drivers/scsi/sr_ioctl.c linux-2.4.27/drivers/scsi/sr_ioctl.c
--- linux-2.4.27.orig/drivers/scsi/sr_ioctl.c	Thu Nov 28 15:53:14 2002
+++ linux-2.4.27/drivers/scsi/sr_ioctl.c	Mon Aug  9 15:34:08 2004
@@ -392,9 +392,9 @@
 		sr_cmd[4] = ti->cdti_trk0;
 		sr_cmd[5] = ti->cdti_ind0;
 		sr_cmd[7] = ti->cdti_trk1;
-		sr_cmd[8] = ti->cdti_ind1;
+		sr_cmd[8] = (ti->cdti_ind1 == 99 ? 0 : ti->cdti_ind1);
 
-		result = sr_do_ioctl(target, sr_cmd, NULL, 0, 0, SCSI_DATA_NONE, NULL);
+		result = sr_do_ioctl(target, sr_cmd, NULL, 0, 1, SCSI_DATA_NONE, NULL);
 		if (result == -EDRIVE_CANT_DO_THIS)
 			result = sr_fake_playtrkind(cdi, ti);
 

      reply	other threads:[~2004-08-27 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-27  8:27 CDROMPLAYTRKIND ioctl causing server hang Ganesh_Borse
2004-08-27 16:38 ` Philippe Troin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87llg0tu2u.fsf@ceramic.fifi.org \
    --to=phil@fifi.org \
    --cc=Ganesh_Borse@Dell.com \
    --cc=linux-kernel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox