From: Hilko Bengen <bengen@hilluzination.de>
To: marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org, perex@suse.cz
Subject: [patch] Fix for minor error in 2.4 /proc/isapnp output
Date: Fri, 06 Feb 2004 15:57:33 +0100 [thread overview]
Message-ID: <87llngs1b6.fsf@hilluzination.de> (raw)
In isapnp_proc.c, the wrong registers from the PnP device are read to
determine the iomem area the device is configured to use. According to
the "Plug and Play ISA Specification Version 1.0a", only bits 23
through 8 of the start address can be retrieved from two one-byte
registers.
The attached patch makes isapnp_proc.c read the right registers.q
Please apply it to the 2.4 tree.
Greetings,
-Hilko
diff -uir orig/linux-2.4.24/drivers/pnp/isapnp_proc.c linux-2.4.24/drivers/pnp/isapnp_proc.c
--- orig/linux-2.4.24/drivers/pnp/isapnp_proc.c 2002-11-29 00:53:14.000000000 +0100
+++ linux-2.4.24/drivers/pnp/isapnp_proc.c 2004-02-06 14:56:45.000000000 +0100
@@ -649,7 +649,7 @@
if (next)
isapnp_printf(buffer, "\n");
for (i = next = 0; i < 4; i++) {
- tmp = isapnp_read_dword(ISAPNP_CFG_MEM + (i << 3));
+ tmp = isapnp_read_word(ISAPNP_CFG_MEM + (i << 3)) << 8;
if (!tmp)
continue;
if (!next) {
reply other threads:[~2004-02-06 15:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87llngs1b6.fsf@hilluzination.de \
--to=bengen@hilluzination.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox