From: Gerd Knorr <kraxel@bytesex.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kernel List <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Frank Davis <fdavis@si.rr.com>
Subject: Re: [patch] add i2c_clients_command()
Date: 03 Apr 2003 10:49:53 +0200 [thread overview]
Message-ID: <87llysc6dq.fsf@bytesex.org> (raw)
In-Reply-To: <20030402190852.B1091@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
> > +void i2c_clients_command(struct i2c_adapter *adap, unsigned int cmd, void *arg)
> > +{
> > + int i;
> > +
> > + down(&adap->list);
> > + for (i = 0; i < I2C_CLIENT_MAX; i++) {
> > + if (NULL == adap->clients[i])
> > + continue;
> This is a horrible algorithm! Please introduce a per-adapter client
> lists.
Well, I can't easily fix that single function. The whole i2c core
manages the clients that way, i.e. the whole i2c subsystem would need
a rewrite ...
Gerd
--
Michael Moore for president!
prev parent reply other threads:[~2003-04-03 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-02 17:06 [patch] add i2c_clients_command() Gerd Knorr
2003-04-02 18:08 ` Christoph Hellwig
2003-04-03 8:49 ` Gerd Knorr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87llysc6dq.fsf@bytesex.org \
--to=kraxel@bytesex.org \
--cc=fdavis@si.rr.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox