The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Yifei Yao <donplat@barrensea.org>
To: W_Armin@gmx.de
Cc: hansg@kernel.org,  ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,donplat@barrensea.org
Subject: Re: [PATCH v5] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro
Date: Sun, 22 Nov 2026 14:08:26 +0800	[thread overview]
Message-ID: <87mrr1iejp.fsf@barrensea.org> (raw)
In-Reply-To: <878q3cc4im.fsf_-_@barrensea.org>

Hello Armin,

A gentle ping on this patch.It has been about 20 days since I posted the
rebased patch.  Could you please take a look when you have a chance?

To avoid any confusion, I have included our previous correspondence
below for reference, along with the rebased patch.

> > Am 11.10.26 um 10:14 schrieb Donjuanplatinum:
> >


> > Does the OEM control center for Windows support battery charging
> > modes? If yes then you should also select
> > UNIWILL_FEATURE_BATTERY_CHARGE_MODES.
> >
> > Other than that the patch looks fine to me, but i would be very happy
> > if you could rebase it on the current for-next branch.
> >
> > Thanks, Armin Wolf

> Hi Armin, I think some of my previous replies may have been missed. I
> have added and tested the battery charging mode:

> > > Can you check if UNIWILL_FEATURE_BATTERY_CHARGE_MODES also works on
> > > your device?  Please note that the embedded controller will still
> > > report to charge the battery to 100%, so this is not a reliable
> > > indicator. Do you know if the Windows OEM app provides such a
> > > setting on this device?
> > >
> > > Thanks, Armin Wolf
> > >

> > I also checked the battery charge modes in the Windows OEM
> > application. The OEM application provides this setting.

> > Additionally, I used the interfaces exposed by the OEM's
> > ACPIDriverDll.dll to test the three charge modes and confirmed that
> > their behavior matches the current implementation in the Uniwill
> > driver.



> > Other than that the patch looks fine to me, but i would be very happy if you
> > could rebase it on the current for-next branch.

> I put the rebased patch here,it now base the for-next:

> >From c45bac93447a52dd2e4a76395202a13c6d91763c Mon Sep 17 00:00:00 2001
> From: Donjuanplatinum <donplat@barrensea.org>
> Date: Mon, 2 Nov 2026 11:03:25 +0800
> Subject: [PATCH] platform/x86: uniwill-laptop: Add support for MECHREVO WUJIE
>  Series 15 X Pro

> Add support for the MECHREVO WUJIE Series 15 X Pro (WUJIE
> Series-X5SP4NAG).

> Signed-off-by: Yifei Yao <donplat@barrensea.org>
> ---
>  drivers/platform/x86/uniwill/uniwill-acpi.c | 22 +++++++++++++++++++++
>  1 file changed, 22 insertions(+)

> diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
> index f62d59f29676..d49be1caea50 100644
> --- a/drivers/platform/x86/uniwill/uniwill-acpi.c
> +++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
> @@ -2715,6 +2715,20 @@ static struct platform_driver uniwill_driver = {
>  	.shutdown = uniwill_shutdown,
>  };
> +static struct uniwill_device_descriptor series_x5sp4nag_descriptor __initdata = {
> +	.features = UNIWILL_FEATURE_FN_LOCK |
> +		    UNIWILL_FEATURE_SUPER_KEY |
> +		    UNIWILL_FEATURE_CPU_TEMP |
> +		    UNIWILL_FEATURE_PRIMARY_FAN |
> +		    UNIWILL_FEATURE_SECONDARY_FAN |
> +                 UNIWILL_FEATURE_BATTERY_CHARGE_MODES |
> +		    UNIWILL_FEATURE_KEYBOARD_BACKLIGHT |
> +		    UNIWILL_FEATURE_AC_AUTO_BOOT |
> +		    UNIWILL_FEATURE_USB_POWERSHARE,
> +	.kbd_led_single_color = false,
> +	.kbd_led_max_brightness = 4,
> +};
> +
>  static struct uniwill_device_descriptor machenike_l16p_descriptor __initdata = {
>  	.features = UNIWILL_FEATURE_FN_LOCK |
>  		    UNIWILL_FEATURE_SUPER_KEY |
> @@ -3075,6 +3089,14 @@ static const struct dmi_system_id uniwill_dmi_table[] __initconst = {
>  		},
>  		.driver_data = &x4sp4nal_descriptor,
>  	},
> +	{
> +		.ident = "MECHREVO WUJIE Series 15 X Pro",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "WUJIE Series-X5SP4NAG"),
> +		},
> +		.driver_data = &series_x5sp4nag_descriptor,
> +	},
>  	{
>  		.ident = "MACHENIKE L16 Pro",
>  		.matches = {
> -- 
> 2.56.0


-- 
Donjuanplatinum, Yifei Yao <donplat@barrensea.org>
GPG: 1C9E EEE5 4C8E D5A8 3039  1C87 A9F6 8632 D259 40E6
满堂兮美人 忽独与余兮目成

      reply	other threads:[~2026-11-22  6:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11  8:14 [PATCH v2] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro Donjuanplatinum
2026-10-11 23:10 ` Armin Wolf
2026-10-12 14:45   ` [PATCH v3] " Donjuanplatinum
2026-10-16  7:49     ` Donjuanplatinum
2026-10-16  8:28       ` [PATCH v3 RESEND] platform/x86: uniwill-laptop: Add support for Donjuanplatinum
2026-10-16 11:36         ` Ilpo Järvinen
2026-10-16 12:08           ` [PATCH v4] platform/x86: uniwill-laptop: Add support for MECHREVO WUJIE Series 15 X Pro Donjuanplatinum
2026-10-28  5:57             ` Yifei Yao
2026-11-01 17:41 ` [PATCH v2] uniwill: " Armin Wolf
2026-11-02  3:10   ` [PATCH v5] " Donjuanplatinum
2026-11-22  6:08     ` Yifei Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mrr1iejp.fsf@barrensea.org \
    --to=donplat@barrensea.org \
    --cc=W_Armin@gmx.de \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox