From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-244108.protonmail.ch (mail-244108.protonmail.ch [109.224.244.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF23536B92B for ; Fri, 7 Aug 2026 07:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786087953; cv=none; b=N8wi8ELMI4AGjb2LAWZgaiKIjhPmMNJuqquY77E3P4J3B01Y++6cgi6gxyah6UcUC4eIODdm976g9TTkcrjYltfMfDE9zpzu38YD9Jo17Xz/s6bnxOOlltY6hwEgQk6FHWDBWQ9a1y1hHH17cmN8XRW0ZslcDaHH16943qOZ0mA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786087953; c=relaxed/simple; bh=unZyHVEipl9wdEWFBpOzZAY8m4Aj3u2FhP2DEVz2+VE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=YnSq/2eMYqzNw6WdY1zl3otd2vjO20lXO1IULKfkcDglYZRug2DvxsT7j506q83TN1vvJ6gSSFRmyWvy6r47u0rWBE1BksBtwEDPZ7/8B9mKnyBLUI7QS/a+ouMcwK+XcOckaJ3IKcKjyMsF1diWeLC5P1loKyrCXqA5tXnscLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=DeG4ygGW; arc=none smtp.client-ip=109.224.244.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="DeG4ygGW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail3; t=1786087929; x=1786347129; bh=unZyHVEipl9wdEWFBpOzZAY8m4Aj3u2FhP2DEVz2+VE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=DeG4ygGW8G2ec6P+5H3tLB1u4xfYKnvgVHhRXMU4YCKQ/JBf6WCGm5yx6hVotC+Ob pTTQ6uLov/tHcDqXEikbq0M7MKtoTigXpNemWOwZwdo9MH5KGA+iVgdftoKY2urYdB wIJh9y/VlqnhcwApTJfFjU5DhDttXIFDHcx+lTXz2FBHewBOftTbUWMO2+b9WxNdhH mVVhepRRT8NZwd8TNgC6dhVWWA+YCjemhdOPQyvCiCijrgG0PY3xq5DJgzXuG5vAAd sHbyVGNnprvOJLLGuTEdMRHAKPsj73HUgBWHToO8gE9GX+Y6ftM3YT6PCKQFueGn/q uFjIEsPhBxztA== X-Pm-Submission-Id: 4hGbSk5SPqz1DDrs From: Esben Haabendal To: "Andy Shevchenko" Cc: "Jonathan Cameron" , "David Lechner" , Nuno =?utf-8?Q?S=C3=A1?= , "Andy Shevchenko" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Nikita Travkin" , "Maslov Dmitry" , "Kuppuswamy Sathyanarayanan" , , , , Subject: Re: [PATCH v3 4/6] iio: light: ltr501: Power down chip if request irq fails In-Reply-To: (Andy Shevchenko's message of "Fri, 07 Aug 2026 00:37:44 +0300") References: <20260804-liteon-ltr329-v3-0-c6b768c7c745@geanix.com> <20260804-liteon-ltr329-v3-4-c6b768c7c745@geanix.com> Date: Fri, 07 Aug 2026 09:32:05 +0200 Message-ID: <87mruyxu6i.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Andy Shevchenko" writes: > On Tue, Aug 04, 2026 at 07:02:15PM +0200, Esben Haabendal wrote: >> In case devm_request_threaded_irq() failed, we were leaving the chip >> powered instead of powering it down again. Power down the chip switching >> ALS and PS modes to standby. >> >> The dev_err() message was causing duplicated error messages, as >> devm_request_threaded_irq() calls dev_err_probe() on failure. > >> Fixes: 7ac702b3144b ("iio: ltr501: Add interrupt support") > > Be careful with this. The removing of the error message should either go > separately, or you should be assured that the IRQ core prints it for you > in all stable kernels where this goes to be backported. Ah yes. The duplicate error message removal is only valid as of 6.18. I will split into a separate patch, and mark it with Fixes against the change in devres.c that prints the error messsage. /Esben