From: Takashi Iwai <tiwai@suse.de>
To: songxiebing <songxiebing@kylinos.cn>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: add missing NULL check for codec->bus->pci
Date: Thu, 30 Jul 2026 11:35:38 +0200 [thread overview]
Message-ID: <87mrv83jmd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260730015302.253008-2-songxiebing@kylinos.cn>
On Thu, 30 Jul 2026 03:53:02 +0200,
songxiebing wrote:
>
> From: Bob Song <songxiebing@kylinos.cn>
>
> In alc269_probe(), codec->bus->pci is dereferenced without a NULL check
> for the ALC236 vendor ID case. Add the missing check, consistent with
> the existing pattern used elsewhere in the same function.
>
> Signed-off-by: Bob Song <songxiebing@kylinos.cn>
> ---
> v2:
> - Separate processing of return values from reading COEF and
> null pointer detection for device.
Applied to for-next branch now. Thanks.
Takashi
next prev parent reply other threads:[~2026-07-30 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 6:38 [PATCH] ALSA: hda/realtek: add missing error checks in alc269 init/shutdown songxiebing
2026-07-29 7:35 ` Takashi Iwai
2026-07-30 1:53 ` [PATCH v2] ALSA: hda/realtek: add missing error checks for COEF index reads in alc269 songxiebing
2026-07-30 1:53 ` [PATCH v2] ALSA: hda/realtek: add missing NULL check for codec->bus->pci songxiebing
2026-07-30 9:35 ` Takashi Iwai [this message]
2026-07-30 9:35 ` [PATCH v2] ALSA: hda/realtek: add missing error checks for COEF index reads in alc269 Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrv83jmd.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=songxiebing@kylinos.cn \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox