The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Mukesh Kumar Chaurasiya <mkchauras@gmail.com>,
	Andreas Schwab <schwab@linux-m68k.org>
Cc: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
	ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com,
	dvyukov@google.com, vincenzo.frascino@arm.com, oleg@redhat.com,
	kees@kernel.org, luto@amacapital.net, wad@chromium.org,
	mchauras@linux.ibm.com, sshegde@linux.ibm.com, thuth@redhat.com,
	ruanjinjie@huawei.com, akpm@linux-foundation.org,
	macro@orcam.me.uk, ldv@strace.io, charlie@rivosinc.com,
	deller@gmx.de, kevin.brodsky@arm.com, ritesh.list@gmail.com,
	yeoreum.yun@arm.com, agordeev@linux.ibm.com,
	segher@kernel.crashing.org, mark.rutland@arm.com,
	ryan.roberts@arm.com, pmladek@suse.com,
	feng.tang@linux.alibaba.com, peterz@infradead.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	kasan-dev@googlegroups.com
Subject: Re: [PATCH v5 0/8] Generic IRQ entry/exit support for powerpc
Date: Wed, 15 Jul 2026 13:34:29 +0206	[thread overview]
Message-ID: <87mrvstrtu.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <ak0uuO-rhItbx9uw@li-1a3e774c-28e4-11b2-a85c-acc9f2883e29.ibm.com>

Hi Mukesh,

On 2026-07-07, Mukesh Kumar Chaurasiya <mkchauras@gmail.com> wrote:
> On Tue, Jul 07, 2026 at 06:34:45PM +0200, Andreas Schwab wrote:
>> On Jul 07 2026, Mukesh Kumar Chaurasiya wrote:
>> 
>> > diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h
>> > index fc636c42e89a..b6373bae4524 100644
>> > --- a/arch/powerpc/include/asm/entry-common.h
>> > +++ b/arch/powerpc/include/asm/entry-common.h
>> > @@ -286,14 +286,6 @@ static inline void arch_interrupt_async_enter_prepare(struct pt_regs *regs)
>> >  
>> >  static inline void arch_interrupt_async_exit_prepare(struct pt_regs *regs)
>> >  {
>> > -       /*
>> > -        * Adjust at exit so the main handler sees the true NIA. This must
>> > -        * come before irq_exit() because irq_exit can enable interrupts, and
>> > -        * if another interrupt is taken before nap_adjust_return has run
>> > -        * here, then that interrupt would return directly to idle nap return.
>> > -        */
>> > -       nap_adjust_return(regs);
>> > -
>> >         arch_interrupt_exit_prepare(regs);
>> >  }
>> >  
>> > diff --git a/arch/powerpc/include/asm/interrupt.h b/arch/powerpc/include/asm/interrupt.h
>> > index fb42a664ae54..1b45a49e9bed 100644
>> > --- a/arch/powerpc/include/asm/interrupt.h
>> > +++ b/arch/powerpc/include/asm/interrupt.h
>> > @@ -246,6 +246,7 @@ interrupt_handler void func(struct pt_regs *regs)                   \
>> >         instrumentation_begin();                                        \
>> >         irq_enter_rcu();                                                \
>> >         ____##func (regs);                                              \
>> > +       nap_adjust_return(regs);                                        \
>> >         irq_exit_rcu();                                                 \
>> >         instrumentation_end();                                          \
>> >         arch_interrupt_async_exit_prepare(regs);                        \
>> 
>> This allows the system to boot normally.
>> 
> Thanks for testing this. I am assuming you tried this without
> "powersave=off" command line option.

I am here after bisecting the same problem. (I also use a G5.)

I can also confirm that the above hack on top of v7.2-rc3 will boot
(without specifying powersave=off).

John Ogness

      reply	other threads:[~2026-07-15 11:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 12:27 [PATCH v5 0/8] Generic IRQ entry/exit support for powerpc Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 1/8] powerpc: rename arch_irq_disabled_regs Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 2/8] powerpc: Prepare to build with generic entry/exit framework Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 3/8] powerpc: introduce arch_enter_from_user_mode Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 4/8] powerpc: Introduce syscall exit arch functions Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 5/8] powerpc: add exit_flags field in pt_regs Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 6/8] powerpc: Prepare for IRQ entry exit Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 7/8] powerpc: Enable GENERIC_ENTRY feature Mukesh Kumar Chaurasiya (IBM)
2026-04-27 12:27 ` [PATCH v5 8/8] powerpc: Remove unused functions Mukesh Kumar Chaurasiya (IBM)
2026-06-19 21:59 ` [PATCH v5 0/8] Generic IRQ entry/exit support for powerpc Madhavan Srinivasan
2026-06-23 11:11 ` Michal Suchánek
2026-06-24  7:38   ` Mukesh Kumar Chaurasiya
2026-07-04 15:49 ` Andreas Schwab
2026-07-05  6:49   ` Christophe Leroy (CS GROUP)
2026-07-05 11:35     ` Andreas Schwab
2026-07-07  4:29       ` Shrikanth Hegde
2026-07-07 16:08         ` Andreas Schwab
2026-07-05 12:02     ` Andreas Schwab
2026-07-06  6:02       ` Shrikanth Hegde
2026-07-06 15:26         ` Andreas Schwab
2026-07-06 19:21         ` Andreas Schwab
2026-07-05 18:00     ` Andreas Schwab
2026-07-07  6:05       ` Mukesh Kumar Chaurasiya
2026-07-07 16:34         ` Andreas Schwab
2026-07-07 16:54           ` Mukesh Kumar Chaurasiya
2026-07-15 11:28             ` John Ogness [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mrvstrtu.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=charlie@rivosinc.com \
    --cc=chleroy@kernel.org \
    --cc=deller@gmx.de \
    --cc=dvyukov@google.com \
    --cc=feng.tang@linux.alibaba.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kees@kernel.org \
    --cc=kevin.brodsky@arm.com \
    --cc=ldv@strace.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luto@amacapital.net \
    --cc=macro@orcam.me.uk \
    --cc=maddy@linux.ibm.com \
    --cc=mark.rutland@arm.com \
    --cc=mchauras@linux.ibm.com \
    --cc=mkchauras@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=ritesh.list@gmail.com \
    --cc=ruanjinjie@huawei.com \
    --cc=ryabinin.a.a@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=schwab@linux-m68k.org \
    --cc=segher@kernel.crashing.org \
    --cc=sshegde@linux.ibm.com \
    --cc=thuth@redhat.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=wad@chromium.org \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox