Re: [RFC PATCH 1/2] scripts: add kconfirm

Nathan Chancellor
2026-04-28T18:31:07Z

On Tue, Apr 28, 2026 at 01:01:29AM -0600, Jonathan Corbet wrote:
> Also, a nit, but I would really suggest putting it under tools/ rather
> than in the scripts/ dumping ground.

As if tools/ isn't its own dumping ground? :)

While I can understand the desire to avoid adding more random stuff to
scripts/, it sets a confusing precedent because tools/ is not a part of
Kbuild, so I would not expect tools that would run within Kbuild to live
there (which this one appears to do). While there are obvious exceptions
such as objtool and resolve_btfids, I would like to avoid adding new
ones, which aligns with the comment added by Masahiro's commit
6e6ef2da3a28 ("Makefile: add comment to discourage tools/* addition for
kernel builds"). Maybe this could be mitigated with a tools/kbuild/
directory or something but not sure. Just some additional input.

Cheers,
Nathan