From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364A939B488 for ; Fri, 10 Apr 2026 07:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775806251; cv=none; b=AqeDNDuzJ5GyCqgCA5kntcJeasSvz66FJHCogBZXJG9fQKR8Qnybu/CA5sjeuYHpAg44E7tjn8rJnPwVeqmg4E7Sjg9NUKJWI/U+eWxkHkj/5RP60OOQlsWwj6+iVc1M+aHcWBG6cttL6oEpFQXhn31GFHcX26PslU8L70/NcHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775806251; c=relaxed/simple; bh=fefobctqhhAWBMd2Rczobto198oUxERBUa7zrMbCkK4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=MmEnw4E9SlQZJxBzKbIkYUpJqchbSjkoB13KDGSO4e0yfYsZQIuMuI7xo882QbZ3QBAhE7KSCyfPw+kZGtl+0Xq+ObJgoWUU557Ws0nPFSw/BRwobm0aumaOgBOWEMKYhR6SvCjREY0rwplrNWiLRx2OyuhFmphqBhYQCG0luao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=O3QZRBta; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=pSKXNJ22; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=O3QZRBta; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=pSKXNJ22; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="O3QZRBta"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="pSKXNJ22"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="O3QZRBta"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="pSKXNJ22" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2ACC06A7CE; Fri, 10 Apr 2026 07:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775806245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7aHj3oK9JXSIh9AS0Iv53/M1IdcI4XhOk0ZLdLpAtb0=; b=O3QZRBtaRUQt0T8UcSgvoXMF2Ptlr1plKmeLGwSJ0DNxO1N7k3NKDRAr86OUaEAZbja+SE NfJvWYsQQ//daQhvH0rlSq8lPCA1Q60twekt0aXOePXQdoDMiVmbekZRYz1M/2aX7y1fVy Z2rYzCqvF6dyC1hi6djBQVXFr4dIF/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775806245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7aHj3oK9JXSIh9AS0Iv53/M1IdcI4XhOk0ZLdLpAtb0=; b=pSKXNJ227DgZ95d3qwmWwPJOdb1ygW26IXKk4bX/2wd9qs2/Z6qwbaLyt6EXtTt4hAuKeq 6aPel+8XrNUaWeBA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775806245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7aHj3oK9JXSIh9AS0Iv53/M1IdcI4XhOk0ZLdLpAtb0=; b=O3QZRBtaRUQt0T8UcSgvoXMF2Ptlr1plKmeLGwSJ0DNxO1N7k3NKDRAr86OUaEAZbja+SE NfJvWYsQQ//daQhvH0rlSq8lPCA1Q60twekt0aXOePXQdoDMiVmbekZRYz1M/2aX7y1fVy Z2rYzCqvF6dyC1hi6djBQVXFr4dIF/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775806245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7aHj3oK9JXSIh9AS0Iv53/M1IdcI4XhOk0ZLdLpAtb0=; b=pSKXNJ227DgZ95d3qwmWwPJOdb1ygW26IXKk4bX/2wd9qs2/Z6qwbaLyt6EXtTt4hAuKeq 6aPel+8XrNUaWeBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E15A74A0B2; Fri, 10 Apr 2026 07:30:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ixCzNSSn2GmTSAAAD6G6ig (envelope-from ); Fri, 10 Apr 2026 07:30:44 +0000 Date: Fri, 10 Apr 2026 09:30:44 +0200 Message-ID: <87mrzbgtln.wl-tiwai@suse.de> From: Takashi Iwai To: Krzysztof Kozlowski Cc: Takashi Iwai , Lei Huang , perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Lei Huang Subject: Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}') In-Reply-To: <2475f220-b0ff-4ee6-b897-75de87d68f81@kernel.org> References: <20260331075405.78148-1-huanglei814@163.com> <87wlyss93y.wl-tiwai@suse.de> <460e5a49-dd85-41fe-9d35-0c4e7efc0ceb@kernel.org> <2475f220-b0ff-4ee6-b897-75de87d68f81@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[163.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[8]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_CC(0.00)[suse.de,163.com,perex.cz,suse.com,vger.kernel.org,kylinos.cn]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[kylinos.cn:email,imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -3.30 X-Spam-Level: On Fri, 10 Apr 2026 09:11:39 +0200, Krzysztof Kozlowski wrote: > > On 01/04/2026 12:43, Krzysztof Kozlowski wrote: > > On 31/03/2026 10:20, Takashi Iwai wrote: > >> On Tue, 31 Mar 2026 09:54:05 +0200, > >> Lei Huang wrote: > >>> > >>> From: Lei Huang > >>> > >>> Fix checkpatch code style errors: > >>> > >>> ERROR: else should follow close brace '}' > >>> #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300: > >>> + } > >>> + else > >>> > >>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT") > >>> Signed-off-by: Lei Huang > >> > >> Thanks, applied to for-next branch. > > > > I hope you dropped the fake Fixes tag. Or at least give people chance to > > review it. > > I see you entirely ignored all the comments about fake bug being fixed here. I saw your comments, but I have a different opinion. In the case of HD-audio code where the code change happens very actively and quite often backported to stable trees, a change like this would block the further backports if missing. With a hint of Fixes tag, the change of the code change can be tracked more easily, hence it's still worth to have. thanks, Takashi