From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2F7339F172 for ; Mon, 30 Mar 2026 19:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774900134; cv=none; b=Axqr6a9GamOdw7aWViWBInuyD6KNiIY1G4YW5C0vSjDh5FwxnvB66gTlRGgjrDajhx3FKJ1ikU5mST0BzJG1+QuubM7D4U98+Hz/0B3TBuLUnrvK5GmmTcEagHzHVA+YbxEd+CAbHsbONuPA5R5R3jFTHsGXAbw6yt5qiLnIQKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774900134; c=relaxed/simple; bh=eJFFCmN6W74PgTQwp6cGQcZX08Q+JghE5sILgKnD+7A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=F02uHkZQpWA4Zj2+Vh+zP4eHSsx6xXyKztDjrDacM34dGeiVfslFMZbzmusBxtZTCqRrUsByFdsIrDc+MhbosaI5wCRUWOgFc8FWjYBMDB65N9uRd0FEOAxjHy7kMoo0AuMZB5hXY7Zwz+Q1o5sfmAq+eZWwLyKN/JGK09ij5uY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SW4xUhET; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SW4xUhET" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FF97C2BCB1; Mon, 30 Mar 2026 19:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774900134; bh=eJFFCmN6W74PgTQwp6cGQcZX08Q+JghE5sILgKnD+7A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SW4xUhETAzGz/awJMAym2kCKfrCS9E2EFKTd+I96LEmwoKBb7Xks+yzTe1lHwfYWn cbDC+guonS7xuCpwWz2FrEMmwbQVcnJ7uFz+otXkqkKONZKlj5Ad3GvDtF28RaIYmN 3cd4XtoLZTh3OJUlFhatodiwUj4MLNk2rBJPGwGlXl4lq1RDH7i7orDuaJgi3NPECu fRcL5yUK1ivRtQ8JDhWRGzrfMBWf5rfsKwIUNqmtCqlZ1wRKUlb4CsGYdA9/0Jbu9I NidQG4yOJ26RGKu2K6a1JkexPlUZjORbSKKFxwWjGYmGB8NYslvfH2jtd6HaWI569v /kuxb9xEAU+wQ== From: Thomas Gleixner To: Mark Rutland Cc: LKML , Mathieu Desnoyers , =?utf-8?Q?Andr=C3=A8?= Almeida , Sebastian Andrzej Siewior , Carlos O'Donell , Peter Zijlstra , Florian Weimer , Rich Felker , Torvald Riegel , Darren Hart , Ingo Molnar , Davidlohr Bueso , Arnd Bergmann , "Liam R . Howlett" , Uros Bizjak , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Subject: Re: [patch V3 06/14] x86: Select ARCH_MEMORY_ORDER_TOS In-Reply-To: References: <20260330114212.927686587@kernel.org> <20260330120117.467037069@kernel.org> Date: Mon, 30 Mar 2026 21:48:50 +0200 Message-ID: <87mrzp9jz1.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Mar 30 2026 at 14:34, Mark Rutland wrote: > On Mon, Mar 30, 2026 at 02:02:31PM +0200, Thomas Gleixner wrote: >> The generic unsafe_atomic_store_release_user() implementation does: >>=20 >> if (!IS_ENABLED(CONFIG_ARCH_MEMORY_ORDER_TOS)) >> smp_mb(); >> unsafe_put_user(); >>=20 >> As x86 implements Total Store Order (TOS) which means stores imply relea= se, >> select ARCH_MEMORY_ORDER_TOS to avoid the unnecessary smp_mb(). >>=20 >> Signed-off-by: Thomas Gleixner >> Reviewed-by: Andr=C3=A9 Almeida >> --- >> V3: Rename to TOS - Peter > > As on the last patch, shouldn't that be TSO? Duh. Yes. My dyslexia seems to get worse.