From: Thomas Gleixner <tglx@linutronix.de>
To: Tianyang Zhang <zhangtianyang@loongson.cn>,
chenhuacai@kernel.org, kernel@xen0n.name, corbet@lwn.net,
alexs@kernel.org, si.yanteng@linux.dev, jiaxun.yang@flygoat.com,
maobibo@loongson.cn
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tianyang Zhang <zhangtianyang@loongson.cn>,
Liupu Wang <wangliupu@loongson.cn>
Subject: Re: [PATCH v10 4/4] irqchip/irq-loongarch-ir:Add Redirect irqchip support
Date: Mon, 02 Feb 2026 11:07:42 +0100 [thread overview]
Message-ID: <87ms1rfogh.ffs@tglx> (raw)
In-Reply-To: <20260202091041.2278271-5-zhangtianyang@loongson.cn>
On Mon, Feb 02 2026 at 17:10, Tianyang Zhang wrote:
> +static inline void redirect_write_reg64(u32 node, u64 val, u32 reg)
> +{
> + return writeq(val, REDIRECT_REG(reg, node));
Again: What is this return for?
> +static int redirect_table_init(struct irde_desc *irde)
> +{
> + struct redirect_table *ird_table = &irde->ird_table;
> + unsigned long *bitmap;
> + struct folio *folio;
> + int node = irde->node;
It seems to be really hard to do a length based sort.
Oh well...
next prev parent reply other threads:[~2026-02-02 10:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 9:10 [PATCH v10 0/4] Loongarch irq-redirect support Tianyang Zhang
2026-02-02 9:10 ` [PATCH v10 1/4] Docs/LoongArch: Add Advanced Extended-Redirect IRQ model description Tianyang Zhang
2026-02-02 9:10 ` [PATCH v10 2/4] irqchip/irq-loongson.h: irq-loongson.h preparation for Redirect irqchip Tianyang Zhang
2026-02-02 9:59 ` Thomas Gleixner
2026-02-03 1:25 ` Tianyang Zhang
2026-02-02 9:10 ` [PATCH v10 3/4] irqchip/loongarch-avec.c: return IRQ_SET_MASK_OK_DONE when keep affinity Tianyang Zhang
2026-02-02 9:10 ` [PATCH v10 4/4] irqchip/irq-loongarch-ir:Add Redirect irqchip support Tianyang Zhang
2026-02-02 10:07 ` Thomas Gleixner [this message]
2026-02-03 1:33 ` Tianyang Zhang
2026-02-03 9:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms1rfogh.ffs@tglx \
--to=tglx@linutronix.de \
--cc=alexs@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=si.yanteng@linux.dev \
--cc=wangliupu@loongson.cn \
--cc=zhangtianyang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox