From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3050125A62E for ; Mon, 5 Jan 2026 14:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767621859; cv=none; b=s43JLl0nAhphjL8yrUOVxwGwdChEt8nEtsHhhG56WRDWtFKXrh7pmIto4YgsIBSjDvQdIRsFYbcPS/fHCowQKfl5Tj1tcfeuV348rAAJnja/zfiuGXflSmo1YB+eKnIgqni15wzMOtVea7Wt1HCylhsRroz7zmK+Z3dSrEv+1yM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767621859; c=relaxed/simple; bh=E2qz9NPIv3c+HCtvPcFvbZmZrXcLcHj2I72z1V4F49I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZRnedkVSNMc8XgmZoc/AlJS/VV4Q1jzdlepFfOQfcb80I8XQPzYvhhGCSLUsMS4GB7uDaF6dx/VAyJFWIa0cEpP8By+zGS0I/tZmNh2FHW7y3oeGlArfvPLeOzNYJpmmmWj+dELGNfM5Ube+++ZbNdv3hfhzvgtD/VmbMqMQoOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=vpndpMwj; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="vpndpMwj" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id A1DCD1A2666 for ; Mon, 5 Jan 2026 14:04:14 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 75DF660726; Mon, 5 Jan 2026 14:04:14 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D848D103C8541; Mon, 5 Jan 2026 15:04:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767621853; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=upzBh5Em5NXDGqBT4uo4/M1CBjvadt94CRbC6kwOVJ8=; b=vpndpMwjksdg561R687A/0n70utGm4SqoKdTISzY10Fw27IGR+zPXnHdBscgYYw2hE/2KB i5ydNMiF+GA5EYo4/jNYvR04lC5AxgiodRbNIjmyD1e7Yy0yR6wpBpLYHayM+ajPbTvZ2V LI5BZUYBEX9Sxesm5PmcpAW3XBnLhhWRo7XPxiR3TtJrKFgikwMCBqN5qgX09SXILjElnP Q/ih9i50JpADhqyJXRpCrkGyWaZsGc18Q5f1ZAAHUl+OHDn6s7vsUPSEiAWTdwxDXRk2FV C7dBKSwumswMkzM0I26Z1kq3WkOjGrGR+q11lim54z2NQU/6bOYTknv5U+ExyQ== From: Gregory CLEMENT To: Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: Re: [PATCH] soc: dove: pmu: Simplify with scoped for each OF child loop In-Reply-To: <20260102124801.64172-2-krzysztof.kozlowski@oss.qualcomm.com> References: <20260102124801.64172-2-krzysztof.kozlowski@oss.qualcomm.com> Date: Mon, 05 Jan 2026 15:04:11 +0100 Message-ID: <87ms2sqhpg.fsf@BLaptop.bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Krzysztof Kozlowski writes: > Use scoped for-each loop when iterating over device nodes to make code a > bit simpler. > > Signed-off-by: Krzysztof Kozlowski Applied on mvebu/arm Thanks, Gregory > --- > drivers/soc/dove/pmu.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c > index 7bbd3f940e4d..dd8ade8e9ee8 100644 > --- a/drivers/soc/dove/pmu.c > +++ b/drivers/soc/dove/pmu.c > @@ -371,7 +371,7 @@ int __init dove_init_pmu_legacy(const struct dove_pmu= _initdata *initdata) > */ > int __init dove_init_pmu(void) > { > - struct device_node *np_pmu, *domains_node, *np; > + struct device_node *np_pmu, *domains_node; > struct pmu_data *pmu; > int ret, parent_irq; >=20=20 > @@ -404,21 +404,18 @@ int __init dove_init_pmu(void) >=20=20 > pmu_reset_init(pmu); >=20=20 > - for_each_available_child_of_node(domains_node, np) { > + for_each_available_child_of_node_scoped(domains_node, np) { > struct of_phandle_args args; > struct pmu_domain *domain; >=20=20 > domain =3D kzalloc(sizeof(*domain), GFP_KERNEL); > - if (!domain) { > - of_node_put(np); > + if (!domain) > break; > - } >=20=20 > domain->pmu =3D pmu; > domain->base.name =3D kasprintf(GFP_KERNEL, "%pOFn", np); > if (!domain->base.name) { > kfree(domain); > - of_node_put(np); > break; > } >=20=20 > --=20 > 2.51.0 > --=20 Gr=C3=A9gory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com