From: Thomas Gleixner <tglx@linutronix.de>
To: Johan Hovold <johan@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] modpost: drop '*_probe' from section check whitelist
Date: Sat, 15 Nov 2025 16:36:43 +0100 [thread overview]
Message-ID: <87ms4n9uk4.ffs@tglx> (raw)
In-Reply-To: <20251020091613.22562-1-johan@kernel.org>
On Mon, Oct 20 2025 at 11:16, Johan Hovold wrote:
> Several symbol patterns used to be whitelisted to allow drivers to refer
> to functions annotated with __devinit and __devexit, which have since
> been removed.
>
> Commit e1dc1bfe5b27 ("modpost: remove more symbol patterns from the
> section check whitelist") removed most of these patterns but left
> '*_probe' after a reported warning in an irqchip driver.
>
> Turns out that was indeed an incorrect reference which has now been
> fixed by commit 9b685058ca93 ("irqchip/qcom-irq-combiner: Fix section
> mismatch").
>
> A recently added clocksource driver also relies on this suffix to
> suppress another valid warning, and that is being fixed separately. [1]
>
> Note that drivers with valid reasons for suppressing the warnings can
> use the __ref macros.
>
> Link: https://lore.kernel.org/lkml/20251017054943.7195-1-johan@kernel.org/ [1]
> Signed-off-by: Johan Hovold <johan@kernel.org>
Thanks for cleaning this up!
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2025-11-15 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 9:16 [PATCH] modpost: drop '*_probe' from section check whitelist Johan Hovold
2025-10-21 0:20 ` kernel test robot
2025-10-22 20:39 ` Nathan Chancellor
2025-11-12 16:48 ` Johan Hovold
2025-11-14 4:16 ` Nathan Chancellor
2025-11-14 8:45 ` Johan Hovold
2025-12-16 1:11 ` Johan Hovold
2025-11-15 15:36 ` Thomas Gleixner [this message]
2025-12-16 13:13 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms4n9uk4.ffs@tglx \
--to=tglx@linutronix.de \
--cc=johan@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox