public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: Magnus Lindholm <linmag7@gmail.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	 Matt Turner <mattst88@gmail.com>,  Stian Halseth <stian@itx.no>,
	linux-alpha@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] alpha: don't reference obsolete termio struct for TC* constants
Date: Wed, 01 Oct 2025 23:26:35 +0100	[thread overview]
Message-ID: <87ms6axnqc.fsf@gentoo.org> (raw)
In-Reply-To: <CA+=Fv5R=Gtt2BQqRRQz2tntW4nqTB3d-wb9R-0GjHnm-uXgA6w@mail.gmail.com>

Magnus Lindholm <linmag7@gmail.com> writes:

>> +#define TCGETA          0x5405
>> +#define TCSETA          0x5406
>> +#define TCSETAW         0x5407
>> +#define TCSETAF         0x5408
>
> Hi,
>
> A similar patch aimed for powerpc (commit ab10727) had the following
> definitions:
>
> #define TCGETA    0x40147417
> #define TCSETA    0x80147418
> #define TCSETAW 0x80147419
> #define TCSETAF  0x8014741c
>
> On Alpha, if I do something like printf("TCGETA = 0x%08x\n", TCGETA);
> I get TCGETA = 0x40127417, but on an intel/x64 I get 0x5405.
> Is this something we need to consider here?

There are fallback definitions in generic:

tools/include/uapi/asm-generic/ioctls.h:24:#define TCGETA               0x5405
include/uapi/asm-generic/ioctls.h:24:#define TCGETA             0x5405

I think those are used where there was no historical value (i.e. for
newer ioctls). Coud you run something like
https://bugs.gentoo.org/962600#c5 to get the full list of (removed)
constant values for alpha? It's awkward for me to test with older glibc.

>
> Regards
>
> Magnus

thanks,
sam

  reply	other threads:[~2025-10-01 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01 19:42 [PATCH v2 1/3] parisc: don't reference obsolete termio struct for TC* constants Sam James
2025-10-01 19:42 ` [PATCH v2 2/3] alpha: " Sam James
2025-10-01 22:12   ` Magnus Lindholm
2025-10-01 22:26     ` Sam James [this message]
2025-10-01 19:42 ` [PATCH v2 3/3] sparc: " Sam James
2025-10-01 20:16 ` [PATCH v2 1/3] parisc: " Helge Deller
2025-10-01 22:58 ` [PATCH] " Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ms6axnqc.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=linmag7@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    --cc=stian@itx.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox