[PATCH] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4

[PATCH] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4

[Alok Tiwari]

code mistakenly used a hardcoded index (codec[1]) instead of
iterating, over the codec array using the loop variable i.
Use codec[i] instead of codec[1] to match the loop iteration.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 sound/pci/intel8x0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index 51e7f1f1a48e4..b521cec203336 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -2249,7 +2249,7 @@ static int snd_intel8x0_mixer(struct intel8x0 *chip, int ac97_clock,
 			tmp |= chip->ac97_sdin[0] << ICH_DI1L_SHIFT;
 			for (i = 1; i < 4; i++) {
 				if (pcm->r[0].codec[i]) {
-					tmp |= chip->ac97_sdin[pcm->r[0].codec[1]->num] << ICH_DI2L_SHIFT;
+					tmp |= chip->ac97_sdin[pcm->r[0].codec[i]->num] << ICH_DI2L_SHIFT;
 					break;
 				}
 			}
-- 
2.46.0

Re: [PATCH] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4

[Takashi Iwai]

On Sat, 21 Jun 2025 20:52:24 +0200,
Alok Tiwari wrote:
> 
> code mistakenly used a hardcoded index (codec[1]) instead of
> iterating, over the codec array using the loop variable i.
> Use codec[i] instead of codec[1] to match the loop iteration.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Applied now.  Thanks.


Takashi

Re: [PATCH] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4

[Philipp Stanner]

On Sun, 2025-06-22 at 11:28 +0200, Takashi Iwai wrote:
> On Sat, 21 Jun 2025 20:52:24 +0200,
> Alok Tiwari wrote:
> > 
> > code mistakenly used a hardcoded index (codec[1]) instead of
> > iterating, over the codec array using the loop variable i.
> > Use codec[i] instead of codec[1] to match the loop iteration.
> > 
> > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> 
> Applied now.  Thanks.

Shouldn't that have been a bug fix with

Fixes:
and
Cc: stable

?

P.

> 
> 
> Takashi

Re: [PATCH] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4

[Takashi Iwai]

On Mon, 23 Jun 2025 10:02:30 +0200,
Philipp Stanner wrote:
> 
> On Sun, 2025-06-22 at 11:28 +0200, Takashi Iwai wrote:
> > On Sat, 21 Jun 2025 20:52:24 +0200,
> > Alok Tiwari wrote:
> > > 
> > > code mistakenly used a hardcoded index (codec[1]) instead of
> > > iterating, over the codec array using the loop variable i.
> > > Use codec[i] instead of codec[1] to match the loop iteration.
> > > 
> > > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> > 
> > Applied now.  Thanks.
> 
> Shouldn't that have been a bug fix with
> 
> Fixes:
> and
> Cc: stable
> 
> ?

This change likely won't influence on the existing devices, and the
issue has been present from the very beginning of the driver code,
hence no regression.

The stuff in question is about the hardware of over 20 years ago, and
there has been no bug reports about this.  After all, all devices were
with at most two codecs, and this patch is for 3rd and 4th codecs.


thanks,

Takashi