public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Nikolay Borisov <nik.borisov@suse.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Michael Petlan <mpetlan@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/entry: Add __init to ia32_emulation_override_cmdline()
Date: Wed, 11 Dec 2024 16:58:12 +0100	[thread overview]
Message-ID: <87msh2rz3f.fsf@redhat.com> (raw)
In-Reply-To: <df3b71b2-086e-4439-89bc-b55f192f6ab6@suse.com>

Nikolay Borisov <nik.borisov@suse.com> writes:

> On 10.12.24 г. 17:16 ч., Vitaly Kuznetsov wrote:
>> ia32_emulation_override_cmdline() is an early_param() arg and these
>> are only needed at boot time. In fact, all other early_param() functions
>> in arch/x86 seem to have '__init' annotation and
>> ia32_emulation_override_cmdline() is the only exception.
>> 
>> Fixes: a11e097504ac ("x86: Make IA32_EMULATION boot time configurable")
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>
>

Thanks!

> nit: Does it really warrant a Fix tag, it's not a bug per-se, just frees 
> up some memory?

I don't think we have any issues with early_param() functions without
__init currently, by 'Fixes:' I meant "this fixes commit ... which was
sub-optimal" and to help backporters. I'm absolutely fine with dropping
it if that's the consensus.

-- 
Vitaly


  reply	other threads:[~2024-12-11 15:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 15:16 [PATCH] x86/entry: Add __init to ia32_emulation_override_cmdline() Vitaly Kuznetsov
2024-12-11 15:03 ` Nikolay Borisov
2024-12-11 15:58   ` Vitaly Kuznetsov [this message]
2025-01-08 16:05 ` Vitaly Kuznetsov
2025-01-08 17:00   ` Dave Hansen
2025-01-08 17:15     ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msh2rz3f.fsf@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpetlan@redhat.com \
    --cc=nik.borisov@suse.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox