Re: [PATCH 2/2] rtlwifi: Remove more unused functions

[Kalle Valo <kvalo@kernel.org>]

"Dr. David Alan Gilbert" <linux@treblig.org> writes:

> * Kalle Valo (kvalo@kernel.org) wrote:
>> linux@treblig.org writes:
>> 
>> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
>> >
>> > exhalbtc_dbg_control(), exhalbtc_stack_update_profile_info(),
>> > exhalbtc_set_hci_version(), and exhalbtc_set_bt_patch_version() are
>> > unused since their addition in 2014 by
>> > commit aa45a673b291 ("rtlwifi: btcoexist: Add new mini driver")
>> >
>> > Remove them.
>> >
>> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>> 
>> 'wifi:' missing.
>
> Oops, can add that.
>
>> Also in both patches the subject could be more unique.
>
> Do you have suggestions? I don't know the code to give good titles.
> They're both 'btcoexist'; I could merge them into one
>
> wifi: wtlwifi: Remove btcoexist deadcode

No good suggestions really. Usually I add what I'm removing to the
subject but as this patch is removing several functions the subject
would be too long. Maybe something like 'wifi: rtlwifi: remove several
unused exhalbtc_*() functions?' just to throw out some ideas, I'm sure
you can come with better ones.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches