From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A787B194080 for ; Mon, 28 Oct 2024 10:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730112974; cv=none; b=sPwzo51Nk1U9HkBzpPrTDueaUj8DeN5U3zrBuUENKiwv5rK4NNdh6VS26+leGNPoa28/5sEKqBUxQGJxdjoLs+S1Aal385tJR/At4fmEgZJjJ92jHlgxbstk+Z2NUIySfgyRKdxd+YlKjc7wbyzz6aysLYcbGuER7bpoMrPsqD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730112974; c=relaxed/simple; bh=sFua8ZLNFGe+/SF7R0sPYM6WD6XyU3+RBtva+zHRhZg=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=FAqexHiVSxQpXG9H5Li5hNjgEgUHuqzwGefuISND5J9MravdGPCKCwe4E1pFQ1SAlT5k+VwWp67BwvwzjBcgly/JHdNxcTTZcO9POos0kY+Qn/rV7OtqGJX6ZDift49umxRU0Rt61itGgAAprspdbxpoek5pRmSPuf/4eC3equ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J0qs4ExS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J0qs4ExS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24FE0C4CEC3; Mon, 28 Oct 2024 10:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730112974; bh=sFua8ZLNFGe+/SF7R0sPYM6WD6XyU3+RBtva+zHRhZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J0qs4ExSZ+09TQUumkr3JIVnSZ4LNp6gNsnyqrpd0BumW3aEy7K4Inzyl4sWfWyAZ C+7y1LcCiGkJW9xcGXvK2VdZHOc3bPp3cHOUtyKDBAen13hnPM2p+vhyQp22oL/6Qn nY7LH21sgWlCDNumkp1t+RDCevYtjRUzNTJWSh396NoUhMmuML1c+ABJ1uIzRjBHgH IKIz1XbTCXw6sxCreu9yjmMNzyoZMmT4QeEs1tGWUVhISfnuGBJwVSIUEjuhfvO48I HlADIsmcV3Z+79VLAa6pslui/8K/XO+57di374XlJEetl1psYiaaocpU+ykFNb2zUx cYE2gbim1wdwg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t5NPw-007X98-AM; Mon, 28 Oct 2024 10:56:12 +0000 Date: Mon, 28 Oct 2024 10:56:11 +0000 Message-ID: <87msiots1g.wl-maz@kernel.org> From: Marc Zyngier To: Nam Cao Cc: Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Andreas Hindborg , Alice Ryhl , Miguel Ojeda , Kees Cook , Suzuki K Poulose , Joey Gouly , Oliver Upton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/31] KVM: arm64: Switch to use hrtimer_setup() In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: namcao@linutronix.de, anna-maria@linutronix.de, frederic@kernel.org, tglx@linutronix.de, a.hindborg@kernel.org, aliceryhl@google.com, ojeda@kernel.org, kees@kernel.org, suzuki.poulose@arm.com, joey.gouly@arm.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false [+ the rest of the KVM/arm64 maintainers/reviewers] On Mon, 28 Oct 2024 07:31:38 +0000, Nam Cao wrote: > > There is a newly introduced hrtimer_setup() which will replace > hrtimer_init(). This new function is similar to the old one, except that it > also sanity-checks and initializes the timer's callback function. > > Switch to use this new function. > > Signed-off-by: Nam Cao > --- > Cc: Marc Zyngier > --- > arch/arm64/kvm/arch_timer.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c > index 879982b1cc73..92e4fb5dcf52 100644 > --- a/arch/arm64/kvm/arch_timer.c > +++ b/arch/arm64/kvm/arch_timer.c > @@ -993,8 +993,7 @@ static void timer_context_init(struct kvm_vcpu *vcpu, int timerid) > else > ctxt->offset.vm_offset = &kvm->arch.timer_data.poffset; > > - hrtimer_init(&ctxt->hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD); > - ctxt->hrtimer.function = kvm_hrtimer_expire; > + hrtimer_setup(&ctxt->hrtimer, kvm_hrtimer_expire, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD); > > switch (timerid) { > case TIMER_PTIMER: > @@ -1021,8 +1020,8 @@ void kvm_timer_vcpu_init(struct kvm_vcpu *vcpu) > timer_set_offset(vcpu_ptimer(vcpu), 0); > } > > - hrtimer_init(&timer->bg_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD); > - timer->bg_timer.function = kvm_bg_timer_expire; > + hrtimer_setup(&timer->bg_timer, kvm_bg_timer_expire, CLOCK_MONOTONIC, > + HRTIMER_MODE_ABS_HARD); > } > > void kvm_timer_init_vm(struct kvm *kvm) Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.