From: Jonathan Corbet <corbet@lwn.net>
To: Pengyu Zhang <zpenya1314@gmail.com>
Cc: rppt@kernel.org, linus.walleij@linaro.org,
fmdefrancesco@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, yaxin_wang_uestc@163.com,
Pengyu Zhang <zpenya1314@gmail.com>
Subject: Re: [PATCH v2] Docs/mm: Fix a mistake for pfn in page_tables.rst
Date: Mon, 14 Oct 2024 10:16:10 -0600 [thread overview]
Message-ID: <87msj6slrp.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20241009144135.12453-1-zpenya1314@gmail.com>
Pengyu Zhang <zpenya1314@gmail.com> writes:
> The documentation incorrectly calculate the pfn value as 0x3fffff,
> which should be 0x3ffff instead. It is obtained by right-shifting
> 0xffffc000 by 14 bits.
>
> This patch corrects the value to prevent any potential confusion
> for developers referencing this document.
>
> Signed-off-by: Pengyu Zhang <zpenya1314@gmail.com>
> ---
> Documentation/mm/page_tables.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/mm/page_tables.rst b/Documentation/mm/page_tables.rst
> index be47b192a596..e7c69cc32493 100644
> --- a/Documentation/mm/page_tables.rst
> +++ b/Documentation/mm/page_tables.rst
> @@ -29,7 +29,7 @@ address.
> With a page granularity of 4KB and a address range of 32 bits, pfn 0 is at
> address 0x00000000, pfn 1 is at address 0x00001000, pfn 2 is at 0x00002000
> and so on until we reach pfn 0xfffff at 0xfffff000. With 16KB pages pfs are
> -at 0x00004000, 0x00008000 ... 0xffffc000 and pfn goes from 0 to 0x3fffff.
> +at 0x00004000, 0x00008000 ... 0xffffc000 and pfn goes from 0 to 0x3ffff.
>
Applied, thanks.
For future reference, when you submit an updated version of a patch,
please make a note of what has changed below the "---" line. Also, you
didn't pick up Mike's Reviewed-by from the first version; I've added it.
Thanks,
jon
prev parent reply other threads:[~2024-10-14 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 14:41 [PATCH v2] Docs/mm: Fix a mistake for pfn in page_tables.rst Pengyu Zhang
2024-10-09 15:53 ` Linus Walleij
2024-10-10 16:35 ` Zenghui Yu
2024-10-14 16:16 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msj6slrp.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=fmdefrancesco@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=yaxin_wang_uestc@163.com \
--cc=zpenya1314@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox